Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smart information retrieval system for TfidfModel. Fix #1785 #1791

Merged
merged 34 commits into from
Jan 15, 2018
Merged

Add smart information retrieval system for TfidfModel. Fix #1785 #1791

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5e1830b
fixing appveyor
markroxor Oct 20, 2016
6cef4b1
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
markroxor Dec 2, 2016
e8a3f16
verify weights
markroxor Dec 15, 2017
648bf21
verify weights
markroxor Dec 15, 2017
a6f1afb
smartirs ready
markroxor Dec 15, 2017
d091138
change old tests
markroxor Dec 15, 2017
951c549
remove lambdas
markroxor Dec 15, 2017
40c0558
address suggestions
markroxor Dec 16, 2017
b35344c
minor fix
markroxor Dec 19, 2017
0917e75
pep8 fix
markroxor Dec 19, 2017
bef79cc
numpy style doc strings
markroxor Dec 19, 2017
d3d431c
fix pickle problem
menshikh-iv Dec 21, 2017
0e6f21e
flake8 fix
markroxor Dec 21, 2017
7ee7560
fix bug in docstring
menshikh-iv Dec 21, 2017
f2251a4
Merge branch 'develop' of github.com:markroxor/gensim into develop
markroxor Dec 22, 2017
b2def84
added few tests
markroxor Dec 22, 2017
5b2d37a
fix normalize issue for pickling
markroxor Dec 22, 2017
ac4b154
fix normalize issue for pickling
markroxor Dec 22, 2017
0bacc08
test without sklearn api
markroxor Dec 22, 2017
51e0eb9
Merge branch 'smartirs' of github.com:markroxor/gensim into smartirs
markroxor Dec 22, 2017
3039732
hanging idents and new tests
markroxor Dec 25, 2017
99e6a6f
Merge branch 'develop' of https://github.com/RaRe-Technologies/gensim…
markroxor Dec 26, 2017
7d63d9c
Merge branch 'smartirs' of github.com:markroxor/gensim into smartirs
markroxor Dec 26, 2017
e5140f8
add docstring
markroxor Dec 26, 2017
4afbadd
add docstring
markroxor Dec 26, 2017
d2fe235
Merge branch 'smartirs' of github.com:markroxor/gensim into smartirs
markroxor Dec 26, 2017
52ee3c4
better way cmparing floats
markroxor Dec 27, 2017
48e84f7
old way of cmp floats
markroxor Jan 8, 2018
6d2f47b
Merge remote-tracking branch 'upstream/develop' into develop
menshikh-iv Jan 10, 2018
607ba61
Merge branch 'develop' into smartirs
menshikh-iv Jan 10, 2018
d0878a4
doc fix[1]
menshikh-iv Jan 10, 2018
b544c9c
doc fix[2]
menshikh-iv Jan 11, 2018
c4e3656
fix description TODOs
markroxor Jan 11, 2018
98ffde5
fix irksome comparision
markroxor Jan 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gensim/models/tfidfmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def __getitem__(self, bow, eps=1e-12):

vector = [
(termid, tf * self.idfs.get(termid))
for termid, tf in zip(termid_array, tf_array) if self.idfs.get(termid, 0.0) != 0.0
for termid, tf in zip(termid_array, tf_array) if self.idfs.get(termid, 0.0) > eps
Copy link
Owner

@piskvorky piskvorky Dec 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing in absolute value safer (easier to read and comprehend intent; plus less room for error).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a discussion with @menshikh-iv stating otherwise. @menshikh-iv I am reverting this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piskvorky I did the same here, but you asked me to revert it.

]

if self.normalize is True:
Expand Down