Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dict save as text #1443

Closed
wants to merge 2 commits into from
Closed

Fix dict save as text #1443

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e5a72
Fix windows unicode problem
vlejd Jun 22, 2017
dfd3960
Merge branch 'develop' into 56_fix_dict_save_as_text
vlejd Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions gensim/test/test_corpora_dictionary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,9 +182,9 @@ def test_saveAsText(self):
"""`Dictionary` can be saved as textfile. """
tmpf = get_tmpfile('save_dict_test.txt')
small_text = [
["prvé", "slovo"],
["slovo", "druhé"],
["druhé", "slovo"]]
["first", "word"],
["word", "second"],
["second", "word"]]

d = Dictionary(small_text)

Expand All @@ -194,46 +194,46 @@ def test_saveAsText(self):
self.assertEqual(serialized_lines[0], "3\n")
self.assertEqual(len(serialized_lines), 4)
# We do not know, which word will have which index
self.assertEqual(serialized_lines[1][1:], "\tdruhé\t2\n")
self.assertEqual(serialized_lines[2][1:], "\tprvé\t1\n")
self.assertEqual(serialized_lines[3][1:], "\tslovo\t3\n")
self.assertEqual(serialized_lines[1][1:], "\tfirst\t1\n")
self.assertEqual(serialized_lines[2][1:], "\tsecond\t2\n")
self.assertEqual(serialized_lines[3][1:], "\tword\t3\n")

d.save_as_text(tmpf, sort_by_word=False)
with open(tmpf) as file:
serialized_lines = file.readlines()
self.assertEqual(serialized_lines[0], "3\n")
self.assertEqual(len(serialized_lines), 4)
self.assertEqual(serialized_lines[1][1:], "\tslovo\t3\n")
self.assertEqual(serialized_lines[2][1:], "\tdruhé\t2\n")
self.assertEqual(serialized_lines[3][1:], "\tprvé\t1\n")
self.assertEqual(serialized_lines[1][1:], "\tword\t3\n")
self.assertEqual(serialized_lines[2][1:], "\tsecond\t2\n")
self.assertEqual(serialized_lines[3][1:], "\tfirst\t1\n")

def test_loadFromText_legacy(self):
"""
`Dictionary` can be loaded from textfile in legacy format.
Legacy format does not have num_docs on the first line.
"""
tmpf = get_tmpfile('load_dict_test_legacy.txt')
no_num_docs_serialization = "1\tprvé\t1\n2\tslovo\t2\n"
no_num_docs_serialization = "1\tfirst\t1\n2\tword\t2\n"
with open(tmpf, "w") as file:
file.write(no_num_docs_serialization)

d = Dictionary.load_from_text(tmpf)
self.assertEqual(d.token2id[u"prvé"], 1)
self.assertEqual(d.token2id[u"slovo"], 2)
self.assertEqual(d.token2id[u"first"], 1)
self.assertEqual(d.token2id[u"word"], 2)
self.assertEqual(d.dfs[1], 1)
self.assertEqual(d.dfs[2], 2)
self.assertEqual(d.num_docs, 0)

def test_loadFromText(self):
"""`Dictionary` can be loaded from textfile."""
tmpf = get_tmpfile('load_dict_test.txt')
no_num_docs_serialization = "2\n1\tprvé\t1\n2\tslovo\t2\n"
no_num_docs_serialization = "2\n1\tfirst\t1\n2\tword\t2\n"
with open(tmpf, "w") as file:
file.write(no_num_docs_serialization)

d = Dictionary.load_from_text(tmpf)
self.assertEqual(d.token2id[u"prvé"], 1)
self.assertEqual(d.token2id[u"slovo"], 2)
self.assertEqual(d.token2id[u"first"], 1)
self.assertEqual(d.token2id[u"word"], 2)
self.assertEqual(d.dfs[1], 1)
self.assertEqual(d.dfs[2], 2)
self.assertEqual(d.num_docs, 2)
Expand Down