Release 2.8.0 #775
Merged
Release 2.8.0 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we configure the rate-limiter on a per-cluster basis means we need to have the base url set when the option is applied. Turns out we never had that enabled: the new golinstor version will panic when BaseURL() is called before it is properly configured. The fix is to apply these options after the baseurl has been set. To do this, we rearrange the options in the NewClientForCluster method, so that user-added options are always applied last. Signed-off-by: Moritz Wanzenböck <[email protected]>
Requires some minor changes to linstor client helpers, as the golinstor client gained an internal mutex. Also a fix for the release script. Signed-off-by: Moritz Wanzenböck <[email protected]>
Signed-off-by: Moritz Wanzenböck <[email protected]>
Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
release-2.8.0
branch
from
4a32dbe to
b40e62a
Compare
JoelColledge
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests revealed some bugs introduced by updating to the latest golinstor version, so those have been fixed as well.