Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainer: fix remove changefeed and some data race #743

Merged
merged 19 commits into from
Jan 2, 2025
Merged

maintainer: fix remove changefeed and some data race #743

merged 19 commits into from
Jan 2, 2025

Conversation

asddongmen
Copy link
Collaborator

Signed-off-by: dongmen [email protected]

@asddongmen asddongmen marked this pull request as draft December 31, 2024 02:24
@asddongmen asddongmen marked this pull request as ready for review December 31, 2024 06:37
@asddongmen
fix ut
bbdf858 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix it
3217145 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix command error log
5d03a2f 
Signed-off-by: dongmen <[email protected]>
@asddongmen
merge upstream master
ec23da2 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix data race
cbf1318 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix data race 2
d268c65 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix docs
5625f63 
Signed-off-by: dongmen <[email protected]>
@asddongmen
fix panic
91793c0 
Signed-off-by: dongmen <[email protected]>
@asddongmen asddongmen changed the title maintainer: fix pause and resume changefeed ci maintainer: fix remove changefeed Jan 2, 2025
@asddongmen
Copy link
Collaborator Author

After investigation, it was found that the failure of pause + resume CI is related to the processing logic of DDL.
Currently, the DDL processing logic is in the testing and bug-fixing phase.
This PR primarily addresses some data race issues and optimizes the logic to avoid resending excessive unnecessary messages when removing changefeed.
Therefore, it has been decided to merge this PR first, while DDL-related issues will be handled separately in the future.
cc @hongyunyan

@asddongmen asddongmen changed the title maintainer: fix remove changefeed maintainer: fix remove changefeed and some data race Jan 2, 2025
@asddongmen asddongmen merged commit 11ba4e3 into pingcap:master Jan 2, 2025
6 of 8 checks passed
@asddongmen asddongmen deleted the fix-pause-resume-changefeed-it branch January 10, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asddongmen