ext/gd: imageaffinematrixget() strengthening options type check.
#18208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to be also more in line with other imageaffine* calls.
Girgias
requested changes
Apr 1, 2025
ext/gd/gd.c
Outdated
Comment on lines
4145
to
4147
| case IS_STRING: | ||
| x = zval_get_double(tmp); | ||
| break; |
There was a problem hiding this comment.
Won't this return 0 for garbage strings like "string" ? Obviously an improvement over the current situation, but still not amazing. Also this probably will fail for GMP objects which might be supported rn?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be also more in line with other imageaffine* calls.