ext/fileinfo: Various refactorings #18197
Merged
+167
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure is legit |
Girgias
force-pushed
the
fileinfo-minor-refactoring
branch
from
589a8f3 to
622cc2c
Compare
nielsdos
requested changes
Mar 30, 2025
Girgias
force-pushed
the
fileinfo-minor-refactoring
branch
from
622cc2c to
e94d1ce
Compare
nielsdos
approved these changes
Mar 31, 2025
ext/fileinfo/fileinfo.c
Outdated
| /* }}} */ | ||
| const char *ret_val; | ||
| if (path) { | ||
| php_stream_context *context = php_stream_context_from_zval(NULL, false); |
There was a problem hiding this comment.
Nit: could use the php_stream_context_get_default API
| @@ -8,7 +8,7 @@ fileinfo | |||
| $fp = finfo_open(); | |||
| try { | |||
| var_dump(finfo_file($fp, "\0")); | |||
| } catch (\TypeError $e) { | |||
| } catch (\ValueError $e) { | |||
The only way this function returns -1 is if: > magic_setflags() returns -1 on systems that don't support utime(3), or utimes(2) when MAGIC_PRESERVE_ATIME is set. This is extremely unlikely and if this would happen we currently have a return type violation.
Instead of relying on a "god" function
Girgias
force-pushed
the
fileinfo-minor-refactoring
branch
from
e94d1ce to
5458223
Compare
nielsdos
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat supersedes #6189