Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/pdo_firebird: Add LSAN suppression for isc_attach_database() #17544

Merged
merged 1 commit into from
Jan 22, 2025
Merged

ext/pdo_firebird: Add LSAN suppression for isc_attach_database() #17544

merged 1 commit into from
Jan 22, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 22, 2025

No description provided.

@Girgias Girgias marked this pull request as ready for review January 22, 2025 17:32
nielsdos
nielsdos approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

@Girgias Girgias merged commit ad4cbf4 into php:master Jan 22, 2025
10 checks passed
@Girgias Girgias deleted the lsan-suppression branch January 22, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

Assignees
No one assigned
Labels
Extension: pdo_firebird
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos