Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/pdo: Fix memory leak if GC needs to free PDO Statement #17539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/pdo: Fix memory leak if GC needs to free PDO Statement #17539

wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 21, 2025

No description provided.

@Girgias Girgias requested a review from nielsdos January 21, 2025 15:37
nielsdos
nielsdos approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with PDO::FETCH_LAZY too to check if the lazy object also needs to be added, but it seems that object is read only, so it seems we're fine.

nielsdos
nielsdos requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, your firebird test fails with a leak...

@Girgias
Copy link
Member Author

Girgias commented Jan 22, 2025

I think it's the "usual" Firebird leak, so I need to add the boiler plate for that

@Girgias Girgias force-pushed the pdo-fix-memory-leak-cyclic-pdo-stmt branch from e20b3f3 to c7da643 Compare January 23, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos requested changes

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

Assignees
No one assigned
Labels
Extension: pdo (core) Extension: pdo_firebird
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @nielsdos