refactor(errors 🔧): no reason to delay creating error message

goldens/api/@betterer/cli.d.ts

@@ -1,4 +1,4 @@
-export declare type BettererCLIArguments = ReadonlyArray<string>;
+export declare type BettererCLIArguments = Array<string>;
 
 export declare type BettererCLICIConfig = {
     config: BettererCLIArguments;

goldens/api/@betterer/errors.d.ts

@@ -3,7 +3,9 @@ export declare type BettererError = Error & {
     details: BettererErrorDetails;
 };
 
-export declare type BettererErrorDetails = ReadonlyArray<string | Error | BettererError>;
+export declare type BettererErrorDetail = string | ErrorLike | BettererError;
+
+export declare type BettererErrorDetails = ReadonlyArray<BettererErrorDetail>;
 
 export declare type BettererErrorFactory = (...details: BettererErrorDetails) => BettererError;
 
@@ -16,4 +18,4 @@ export declare type ErrorLike = {
 
 export declare function logErrorΔ(err: ErrorLike | Error | BettererError): void;
 
-export declare function registerError(factory: BettererErrorMessageFactory): BettererErrorFactory;
+export declare function registerError(messageFactory: BettererErrorMessageFactory): BettererErrorFactory;

packages/errors/src/error-handler.ts

@@ -3,20 +3,18 @@ import { brΔ, errorΔ } from '@betterer/logger';
 import { BettererErrorΩ } from './error';
 import {
   BettererError,
+  BettererErrorDetail,
   BettererErrorDetails,
   BettererErrorFactory,
   BettererErrorMessageFactory,
   ErrorLike
 } from './types';
 
-const ERROR_MESSAGES = new Map<symbol, BettererErrorMessageFactory>();
+const ERROR_CODES: Array<symbol> = [];
 
 export function logErrorΔ(err: ErrorLike | Error | BettererError): void {
   if (isBettererError(err)) {
-    const factory = ERROR_MESSAGES.get(err.code) as BettererErrorMessageFactory;
     const errors = err.details.filter((detail) => isErrorLike(detail)) as Array<ErrorLike>;
-    const messages = err.details.filter((detail) => !errors.includes(detail as ErrorLike)) as Array<string>;
-    err.message = factory(...messages);
     errorΔ(err.message);
     errors.forEach(logErrorΔ);
     return;
@@ -27,20 +25,21 @@ export function logErrorΔ(err: ErrorLike | Error | BettererError): void {
   brΔ();
 }
 
-export function registerError(factory: BettererErrorMessageFactory): BettererErrorFactory {
+export function registerError(messageFactory: BettererErrorMessageFactory): BettererErrorFactory {
   const code = Symbol();
-  ERROR_MESSAGES.set(code, factory);
+  ERROR_CODES.push(code);
   return function factory(...details: BettererErrorDetails): BettererError {
-    const error = new BettererErrorΩ(code, ...details);
+    const messages = details.filter((detail) => !isErrorLike(detail)) as Array<string>;
+    const error = new BettererErrorΩ(messageFactory(...messages), code, ...details);
     Error.captureStackTrace(error, factory);
     return error;
   };
 }
 
-function isBettererError(err: unknown): err is BettererError {
-  return !!ERROR_MESSAGES.has((err as BettererError).code);
+function isBettererError(err: ErrorLike | Error | BettererError): err is BettererError {
+  return !!ERROR_CODES.includes((err as BettererError).code);
 }
 
-function isErrorLike(err: unknown): err is ErrorLike {
+function isErrorLike(err: BettererErrorDetail): err is ErrorLike {
   return (err as ErrorLike).message != null && (err as ErrorLike).stack !== null;
 }

packages/errors/src/error.ts

@@ -3,8 +3,8 @@ import { BettererError, BettererErrorDetails } from './types';
 export class BettererErrorΩ extends Error implements BettererError {
   public details: BettererErrorDetails;
 
-  constructor(public code: symbol, ...details: BettererErrorDetails) {
-    super();
+  constructor(message: string, public code: symbol, ...details: BettererErrorDetails) {
+    super(message);
 
     Error.captureStackTrace(this, BettererErrorΩ);
     Object.setPrototypeOf(this, new.target.prototype);

packages/errors/src/index.ts

@@ -1,6 +1,7 @@
 export { logErrorΔ, registerError } from './error-handler';
 export {
   BettererError,
+  BettererErrorDetail,
   BettererErrorDetails,
   BettererErrorFactory,
   BettererErrorMessageFactory,

packages/errors/src/types.ts

@@ -3,7 +3,8 @@ export type BettererError = Error & {
   details: BettererErrorDetails;
 };
 
-export type BettererErrorDetails = ReadonlyArray<string | Error | BettererError>;
+export type BettererErrorDetail = string | ErrorLike | BettererError;
+export type BettererErrorDetails = ReadonlyArray<BettererErrorDetail>;
 export type BettererErrorFactory = (...details: BettererErrorDetails) => BettererError;
 export type BettererErrorMessageFactory = (...details: BettererErrorDetails) => string;