Add rudimentary ES2015 module transpilation #26
Conversation
The better approach is to run babel-loader before extract-loader
| // "Transpile" imports | ||
| src = src.replace(/^import\s+(.+)\s+from\s+([^;]+);?$/, "var $1 = require($2);"); | ||
| // "Transpile" default export (other exports are not supported at the moment) | ||
| src = src.replace(/^\s*export\s+default\s*/, "module.exports = "); |
There was a problem hiding this comment.
I don't think we should do that. Replacing strings in the source code is imho too risky and can introduce strange bugs (from the user's perspective). Why not using babel? When there are no plugins, transpiling should be really cheap.
There was a problem hiding this comment.
I agree in general. On the other hand it might not be clear to users of extract-loader, that you need babel in order to use file-loader 1.0.0+. Imho we should at least document that problem in the readme or make the "transpilation" in this PR more specific to the file-loader. What do you think?
|
Just for the record: the file-loader reverted ESM support 3 months ago because of issues in the css-loader. Closing this for now because I think that we should not use that approach. Maybe node's ESM support will come right in time :) Anyway, thanks 👍 |
The better approach is to run babel-loader before extract-loader, but this "transpilation" at least enables file-loader 1.0.0 to integrate without syntax errors.