Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Put github_token as first example #115

Merged
merged 7 commits into from
Feb 24, 2020
Merged

docs: Put github_token as first example #115

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6b36911
docs: Put github_token as first example
peaceiris Feb 19, 2020
cdf9042
docs: move Create SSH Deploy Key
peaceiris Feb 19, 2020
10e7f59
docs: remove github_token section
peaceiris Feb 19, 2020
ece44c6
docs: use github_token instead of deploy_key
peaceiris Feb 24, 2020
281f6b1
docs: remove badge
peaceiris Feb 24, 2020
e137b41
docs: remove How to add CNAME
peaceiris Feb 24, 2020
0b6874b
docs: remove Deployment completed but you cannot read
peaceiris Feb 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: remove github_token section
  • Loading branch information
@peaceiris
peaceiris committed Feb 24, 2020
commit 10e7f590e91cb98f86bbc65d50f15f23a46b56a5
14 changes: 0 additions & 14 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ Three tokens are supported.
- [Options](#options)
- [⭐️ `deploy_key`](#%EF%B8%8F-deploy_key)
- [⭐️ `personal_token`](#%EF%B8%8F-personal_token)
- [⭐️ `github_token`](#%EF%B8%8F-github_token)
- [⭐️ CNAME](#%EF%B8%8F-cname)
- [⭐️ Disable `.nojekyll`](#%EF%B8%8F-disable-nojekyll)
- [⭐️ Allow empty commits](#%EF%B8%8F-allow-empty-commits)
Expand Down Expand Up @@ -220,19 +219,6 @@ Read [⭐️ Create SSH Deploy Key](#%EF%B8%8F-create-ssh-deploy-key), create yo
+ personal_token: ${{ secrets.PERSONAL_TOKEN }}
```

### ⭐️ `github_token`

> ⚠️ **NOTES**: `github_token` works only on a **private** repository.
>
> This action supports `GITHUB_TOKEN` but it has some problems to deploy to GitHub Pages. GitHub team is investigating that. See [Issue #9]

[Issue #9]: https://github.com/peaceiris/actions-gh-pages/issues/9

```diff
- deploy_key: ${{ secrets.ACTIONS_DEPLOY_KEY }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
```

### ⭐️ CNAME

To add `CNAME` file, we can set the `cname` option.
Expand Down