Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PSG-5091 Remove JWK re-fetch logic #95

Merged
merged 10 commits into from
Nov 5, 2024
Merged

refactor: PSG-5091 Remove JWK re-fetch logic #95

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
07d19a2
remove extra call if it can not find it the first time
tdeshong Oct 29, 2024
8f4d87f
clean up removal
tdeshong Oct 29, 2024
c294641
Merge branch 'main' into PSG-5091-remove-jwk-refetch
tdeshong Oct 29, 2024
f253d01
Merge branch 'main' into PSG-5091-remove-jwk-refetch
tdeshong Oct 30, 2024
50c9ff0
refactor: use cacheset instead of individual cache and set
tdeshong Oct 31, 2024
64c9f62
fix: new cache set url
tdeshong Oct 31, 2024
983750b
chore: cleanup
tdeshong Nov 4, 2024
55f194b
Revert "chore: cleanup"
tdeshong Nov 4, 2024
7d13227
fix: add refresh
tdeshong Nov 4, 2024
7f2b010
chore: clean up url
tdeshong Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,8 @@ func (a *App) getPublicKey(token *jwt.Token) (interface{}, error) {
}

key, ok := a.JWKS.LookupKeyID(keyID)
// if key doesn't exist, re-fetch one more time to see if this jwk was just added
if !ok {
if err := a.refreshJWKSCache(); err != nil {
return nil, err
}

key, ok = a.JWKS.LookupKeyID(keyID)
if !ok {
return nil, Error{Message: fmt.Sprintf("unable to find key %q", keyID)}
}
return nil, Error{Message: fmt.Sprintf("unable to find key %q", keyID)}
}

var pubKey interface{}
Expand Down
Loading