Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grafana teleport URL #1585

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Dec 5, 2023

Closes #1584

Allows usage of grafana logs without vpn.

@skunert skunert added the enhancement New feature or request label Dec 5, 2023
@pepoviola
Copy link
Collaborator

Awesome, thanks for your contribution @skunert 🙌

@skunert skunert merged commit 5a6e37c into paritytech:main Dec 5, 2023
10 of 11 checks passed
@skunert skunert deleted the skunert/teleport branch December 5, 2023 14:44
@pepoviola
Copy link
Collaborator

I'm not sure why the nix hash update check fails since this pr doesn't touch any dep. Could be that the nix config is not reading from the lock file?

@wirednkod
Copy link
Contributor

I'm not sure why the nix hash update check fails since this pr doesn't touch any dep. Could be that the nix config is not reading from the lock file?

https://github.com/paritytech/zombienet/actions/runs/7102648724/job/19333502741?pr=1586

@pepoviola
Copy link
Collaborator

I'm not sure why the nix hash update check fails since this pr doesn't touch any dep. Could be that the nix config is not reading from the lock file?

https://github.com/paritytech/zombienet/actions/runs/7102648724/job/19333502741?pr=1586

Thanks @wirednkod, I merged :) But I want to understand how to automate this. I think could be because the orchestrator is itself a dep of the cli but I'm not sure. I will try to check how this works internally.
Thx!

@wirednkod
Copy link
Contributor

I'm not sure why the nix hash update check fails since this pr doesn't touch any dep. Could be that the nix config is not reading from the lock file?

paritytech/zombienet/actions/runs/7102648724/job/19333502741?pr=1586

Thanks @wirednkod, I merged :) But I want to understand how to automate this. I think could be because the orchestrator is itself a dep of the cli but I'm not sure. I will try to check how this works internally. Thx!

Based on a comment, this hash changes with any update of the dependencies, but it is not automatically updated from SRI of package.lock

@pepoviola
Copy link
Collaborator

I'm not sure why the nix hash update check fails since this pr doesn't touch any dep. Could be that the nix config is not reading from the lock file?

paritytech/zombienet/actions/runs/7102648724/job/19333502741?pr=1586

Thanks @wirednkod, I merged :) But I want to understand how to automate this. I think could be because the orchestrator is itself a dep of the cli but I'm not sure. I will try to check how this works internally. Thx!

Based on a comment, this hash changes with any update of the dependencies, but it is not automatically updated from SRI of package.lock

Yes, and as we are using the orchestrator as dep of cli I think any change needs to update the hash. We should automate this in a way that is easy to do it locally.
Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nit: Point log links on CI to grafana.teleport.parity.io
3 participants