Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add missing types #284

Merged
merged 7 commits into from
Sep 2, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
  • Loading branch information
panva authored Sep 2, 2020
commit cdea4eae62c0f559add5a83170f20ca2d2d55f34
2 changes: 1 addition & 1 deletion types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export class Client {
[custom.clock_tolerance]: number;
metadata: ClientMetadata;
issuer: Issuer<this>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also a static version of it, please add that too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

static issuer: Issuer<TClient extends Client>;
static issuer: Issuer<Client>;

/**
* Returns the target authorization redirect URI to redirect End-Users to using the provided parameters.
Expand Down