Reformatting and upgrade to clang-19 #1701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump clang-format to 19, and fix contrib/format.sh so that it doesn't just exit silently when it can't find clang-format-NN. (The set -e was too early and the comparisons against $? where the errors were supposed to be printed never actually happened).
Includes some minor fixes to fix compilation that broke with the formatting.
A typo in the format script meant it wasn't formatting .inl files.
Unfortunately enabling the clang-format rule breaks all uses of OXEN_DEFER, so I just used clang-format to find and eliminate them without enabling the rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and re-runs the formatting script:
.inlfiles, tests, and epee