feat(xdsl.modem.template): use constant

ovh-ux · Jun 11, 2019 · 7943fdf · 7943fdf
1 parent b001b90
commit 7943fdf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/client/app/telecom/pack/xdsl/modem/templates/pack-xdsl-modem-template.constant.js b/client/app/telecom/pack/xdsl/modem/templates/pack-xdsl-modem-template.constant.js
@@ -0,0 +1,6 @@
+angular.module('managerApp').constant('PACK_XDSL_MODEM_TEMPLATE', {
+  errors: {
+    duplicate: 'TemplateName',
+    invalid: 'Invalid',
+  },
+});
diff --git a/client/app/telecom/pack/xdsl/modem/templates/pack-xdsl-modem-templates.controller.js b/client/app/telecom/pack/xdsl/modem/templates/pack-xdsl-modem-templates.controller.js
@@ -1,14 +1,15 @@
 angular.module('managerApp').controller('XdslModemTemplateCtrl', class XdslModemTemplateCtrl {
   /* @ngInject */
   constructor($stateParams, $translate, $uibModal, OvhApiXdsl, TucPackXdslModemMediator,
-    TucToast) {
+    TucToast, PACK_XDSL_MODEM_TEMPLATE) {
     this.$stateParams = $stateParams;
     this.$translate = $translate;
     this.$uibModal = $uibModal;
     this.mediator = TucPackXdslModemMediator;
     this.OvhApiXdsl = OvhApiXdsl;
     this.templateName = null;
     this.TucToast = TucToast;
+    this.TEMPLATE_CONSTANT = PACK_XDSL_MODEM_TEMPLATE;
   }
 
   /*= =====================================
@@ -47,9 +48,9 @@ angular.module('managerApp').controller('XdslModemTemplateCtrl', class XdslModem
       this.getModemTemplates();
     }).catch((err) => {
       let errorMessage = '';
-      if (err.data.message.includes('TemplateName')) {
+      if (err.data.message.includes(this.TEMPLATE_CONSTANT.errors.duplicate)) {
         errorMessage = this.$translate.instant('xdsl_modem_template_name_already_exist', { templateName: this.templateName });
-      } else if (err.data.message.includes('Invalid')) {
+      } else if (err.data.message.includes(this.TEMPLATE_CONSTANT.errors.invalid)) {
         errorMessage = this.$translate.instant('xdsl_modem_template_invalid_name', { templateName: this.templateName });
       } else {
         errorMessage = this.$translate.instant('xdsl_modem_template_an_error_ocurred');