Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use headers instead of deprecated getheaders() in urllib3 (Python SDK) #308

Closed

Conversation

andreagrandi
Copy link

@andreagrandi andreagrandi commented Dec 1, 2023

In urllib3 the use of getheaders() method is deprecated:

DeprecationWarning: HTTPResponse.getheaders() is deprecated and will be removed in urllib3 v2.1.0. Instead access HTTPResponse.headers directly.

Calls to self.urllib3_response.getheaders() should be replaced with self.urllib3_response.headers to fix this warning.

This pull request fixes the usage of getheaders() by removing the usage of the deprecated method.

Related Issue or Design Document

See the above description for the issue explaination.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.

Further comments

None

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2023

CLA assistant check
All committers have signed the CLA.

@andreagrandi andreagrandi changed the title Python SDK: Use headers instead of deprecated getheaders() in urllib3 Fix: Python SDK - Use headers instead of deprecated getheaders() in urllib3 Dec 1, 2023
@andreagrandi andreagrandi changed the title Fix: Python SDK - Use headers instead of deprecated getheaders() in urllib3 fix: Python SDK - Use headers instead of deprecated getheaders() in urllib3 Dec 1, 2023
@andreagrandi andreagrandi changed the title fix: Python SDK - Use headers instead of deprecated getheaders() in urllib3 fix: use headers instead of deprecated getheaders() in urllib3 (Python SDK) Dec 1, 2023
@andreagrandi andreagrandi marked this pull request as ready for review December 1, 2023 09:23
@aeneasr
Copy link
Member

aeneasr commented Mar 24, 2024

Unfortunately, these are auto-generated files and these changes won't have an effect

@aeneasr aeneasr closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants