Add SmoothQuant and ChannelAlignment to HyperparameterTuner #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2154 +/- ##
===========================================
+ Coverage 36.57% 36.62% +0.04%
===========================================
Files 484 486 +2
Lines 43310 43373 +63
===========================================
+ Hits 15841 15885 +44
- Misses 27469 27488 +19
|
andrey-churkin
force-pushed
the
ac/add_pipeline
branch
3 times, most recently
from
a0e42ff to
cbeb182
Compare
andreyanufr
reviewed
Sep 25, 2023
nncf/quantization/algorithms/hyperparameter_tuner/param_grid.py
Outdated
Show resolved
Hide resolved
alexsu52
reviewed
Sep 26, 2023
github-actions
bot
added
NNCF PT
andrey-churkin
force-pushed
the
ac/add_pipeline
branch
2 times, most recently
from
183412a to
8575880
Compare
andrey-churkin
force-pushed
the
ac/add_pipeline
branch
from
b1da295 to
5670c04
Compare
nikita-malininn
approved these changes
Sep 29, 2023
andreyanufr
approved these changes
Oct 4, 2023
andrey-churkin
force-pushed
the
ac/add_pipeline
branch
2 times, most recently
from
5346d9b to
e95b8a2
Compare
|
Build: 10740 |
Comment on lines
-182
to
-189
| for algorithm in self.first_stage_algorithms: | ||
| if isinstance(algorithm, SmoothQuant) and backend != BackendType.OPENVINO: | ||
| nncf_logger.debug(f"{backend.name} does not support SmoothQuant algorithm yet.") | ||
| continue | ||
|
|
||
| if isinstance(algorithm, ChannelAlignment) and backend != BackendType.OPENVINO: | ||
| nncf_logger.debug(f"{backend.name} does not support ChannelAlignment algorithm yet.") | ||
| continue |
There was a problem hiding this comment.
Looks like this part is missing in the new realization, quantization of transformers for torch backend is failing because pipeline tries to apply smoothquant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pipelineclass. To use the algorithm with theHyperparameterTuner, it should be wrapped within aPipelineobject.Reason for changes
Related tickets
Ref: 117471
Tests