Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Better errors and properly set exit code in more cases #418

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Jan 22, 2025

  • validates assertions before validating root sig (faster, errors match those expected in xtest)
  • removes some unused code (remote keys)
  • lets CLI tool properly return non-zero status code on more conditions

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner January 22, 2025 22:24
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
78.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Member

@elizabethhealy elizabethhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can we run the xtest pr against this branch to ensure these changes fix the failures

@dmihalcik-virtru dmihalcik-virtru merged commit 11ad526 into main Jan 23, 2025
11 of 12 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/simpler-decrypt branch January 23, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants