Issue manager and advanced validation

css/80_app.css

@@ -352,6 +352,8 @@ button.secondary-action:hover {
     background: #cccccc;
 }
 
+button.action.disabled,
+button.action.disabled:hover,
 button[disabled].action,
 button[disabled].action:hover {
     background: #cccccc;
@@ -1184,18 +1186,23 @@ img.tag-reference-wiki-image {
 
 /* Entity/Preset Editor
 ------------------------------------------------------- */
+.entity-issues,
 .preset-editor {
     overflow: hidden;
     padding: 10px 0px 5px 0px;
 }
+.entity-issues a.hide-toggle,
 .preset-editor a.hide-toggle {
     margin: 0 20px 5px 20px;
 }
+.entity-issues .disclosure-wrap-entity_issues,
 .preset-editor .form-fields-container {
     padding: 10px;
     margin: 0 10px 10px 10px;
     border-radius: 8px;
+    background: #ececec;
 }
+.entity-issues .disclosure-wrap-entity_issues:empty,
 .preset-editor .form-fields-container:empty {
     display: none;
 }
@@ -2368,14 +2375,23 @@ input.key-trap {
 .inspector-hover button,
 .inspector-hover input,
 .inspector-hover textarea,
-.inspector-hover label {
+.inspector-hover label,
+.inspector-hover .entity-issues .issue button {
     background: #ececec;
 }
 .inspector-hover .preset-list-button,
 .inspector-hover .tag-row input {
     background: #f6f6f6;
 }
 
+.inspector-hover .entity-issues .issue,
+.inspector-hover .entity-issues .issue li {
+    border: 1px solid #ccc;
+}
+.inspector-hover .entity-issues .issue .icon {
+    color: #666;
+}
+
 .inspector-hover a,
 .inspector-hover .form-field-input-multicombo .chips,
 .inspector-hover .form-field-input-check span {
@@ -2402,7 +2418,8 @@ input.key-trap {
 .inspector-hover .form-field-input-radio label,
 .inspector-hover .form-field-input-radio label span,
 .inspector-hover .form-field-input-radio label.remove .icon,
-.inspector-hover .inspector-inner .add-row {
+.inspector-hover .inspector-inner .add-row,
+.inspector-hover .entity-issues .issue ul.issue-fix-list {
     display: none;
 }
 
@@ -2811,11 +2828,11 @@ div.full-screen > button:hover {
     border-radius: 4px;
 }
 
-.layer-list li {
-    position: relative;
+.layer-list > li {
     height: 30px;
     background-color: #fff;
     color: #7092ff;
+    position: relative;
 }
 
 .layer-list:empty {
@@ -2911,6 +2928,121 @@ div.full-screen > button:hover {
 }
 
 
+/* Issues
+------------------------------------------------------- */
+.issue {
+    overflow: hidden;
+}
+.issue button {
+    padding: 5px 10px 5px 5px;
+    height: auto;
+    width: 100%;
+    font-weight: inherit;
+    border-radius: 0;
+}
+[dir='rtl'] .issue button {
+    padding: 5px 5px 5px 10px;
+}
+
+.issue button.label {
+    text-align: inherit;
+    display: flex;
+}
+.warnings-list,
+.issue.severity-warning,
+.issue.severity-warning li,
+ li.issue.severity-warning {
+    border-color: #FFDF5C;
+}
+.errors-list,
+.issue.severity-error,
+.issue.severity-error li,
+ li.issue.severity-error {
+    border-color: #f5b0ab;
+}
+
+.issue.severity-warning button,
+.mode-save .warning-section {
+    background: #ffb;
+}
+.issue.severity-warning button:hover,
+.issue.severity-warning button:focus {
+    background: #FFFF99;
+}
+.issue.severity-warning .icon {
+    color: #FFB300
+}
+
+.issue.severity-error button,
+.mode-save .error-section {
+    background: #FFD5D4;
+}
+.issue.severity-error button:hover,
+.issue.severity-error button:focus {
+    background: #ffc9c7;
+}
+.issue.severity-error .icon {
+    color: #DD1400
+}
+
+/* Issues Pane */
+
+.issues-list label {
+    padding: 5px;
+}
+.issues-list label > span {
+    display: inline;
+    white-space: normal;
+}
+.issues-list li {
+    height: auto;
+    color: inherit;
+    position: static;
+}
+
+.issues-none {
+    border-radius: 4px;
+    border: 1px solid #72D979;
+    background: #C6FFCA;
+    padding: 5px !important;
+    display: flex;
+    margin-top: 5px;
+}
+.issues-none .icon {
+    color: #05AC10;
+}
+
+/* Entity Issues List */
+.entity-issues .issue {
+    border-radius: 4px;
+    border-width: 1px;
+    border-style: solid;
+}
+.entity-issues .issue:not(:last-of-type) {
+    margin-bottom: 10px;
+}
+ul.issue-fix-list li:first-child {
+    border-top-style: solid;
+    border-top-width: 2px;
+}
+ul.issue-fix-list li:not(:last-of-type) {
+    border-bottom-style: solid;
+    border-bottom-width: 1px;
+}
+.issue:not(.expanded) ul.issue-fix-list {
+    height: 0px;
+    transition: height 75ms linear;
+    -moz-transition: height 75ms linear;
+    -webkit-transition: height 75ms linear;
+}
+.issue.expanded ul.issue-fix-list {
+    height: 100%;
+    transition: height 75ms linear;
+    -moz-transition: height 75ms linear;
+    -webkit-transition: height 75ms linear;
+}
+
+
 /* Background - Display Options Sliders
 ------------------------------------------------------- */
 .display-options-container {
@@ -4247,14 +4379,6 @@ svg.mouseclick use.right {
     margin-bottom: 10px;
 }
 
-.mode-save .warning-section {
-    background: #ffb;
-}
-
-.mode-save .error-section {
-    background: #ffa5a5;
-}
-
 .mode-save .warning-section .changeset-list button {
     border-left: 1px solid #ccc;
 }
@@ -4382,6 +4506,7 @@ svg.mouseclick use.right {
     color: #333;
     font-size: 12px;
     white-space: initial;
+    pointer-events: none;
 }
 .tooltip.in {
     opacity: 0.9;

data/core.yaml

@@ -330,6 +330,8 @@ en:
     modified: Modified
     deleted: Deleted
     created: Created
+    outstanding_errors_message: "Please resolve all errors first. {count} remaining."
+    comment_needed_message: Please add a changeset comment first.
     about_changeset_comments: About changeset comments
     about_changeset_comments_link: //wiki.openstreetmap.org/wiki/Good_changeset_comments
     google_warning: "You mentioned Google in this comment: remember that copying from Google Maps is strictly forbidden."
@@ -637,24 +639,6 @@ en:
     description: Description
     on_wiki: "{tag} on wiki.osm.org"
     used_with: "used with {type}"
-  validations:
-    disconnected_highway: Disconnected highway
-    disconnected_highway_tooltip: "Roads should be connected to other roads or building entrances."
-    generic_name: Possible generic name
-    generic_name_tooltip: 'This feature seems to have a generic name "{name}". Please only use the name field to record the official name of a feature.'
-    old_multipolygon: Multipolygon tags on outer way
-    old_multipolygon_tooltip: "This style of multipolygon is deprecated. Please assign the tags to the parent multipolygon instead of the outer way."
-    untagged_point: Untagged point
-    untagged_point_tooltip: "Select a feature type that describes what this point is."
-    untagged_line: Untagged line
-    untagged_line_tooltip: "Select a feature type that describes what this line is."
-    untagged_area: Untagged area
-    untagged_area_tooltip: "Select a feature type that describes what this area is."
-    untagged_relation: Untagged relation
-    untagged_relation_tooltip: "Select a feature type that describes what this relation is."
-    many_deletions: "You're deleting {n} features: {p} nodes, {l} lines, {a} areas, {r} relations. Are you sure you want to do this? This will delete them from the map that everyone else sees on openstreetmap.org."
-    tag_suggests_area: "The tag {tag} suggests line should be area, but it is not an area"
-    deprecated_tags: "Deprecated tags: {tags}"
   zoom:
     in: Zoom in
     out: Zoom out
@@ -1179,6 +1163,114 @@ en:
           indirect: "**Some restrictions display the text \"(indirect)\" and are drawn lighter.**"
           indirect_example: "These restrictions exist because of another nearby restriction. For example, an \"Only Straight On\" restriction will indirectly create \"No Turn\" restrictions for all other paths through the intersection."
           indirect_noedit: "You may not edit indirect restrictions. Instead, edit the nearby direct restriction."
+  issues:
+    title: Issues
+    key: I
+    list_title: "Issues ({count})"
+    errors:
+      list_title: "Errors ({count})"
+    warnings:
+      list_title: "Warnings ({count})"
+    no_issues:
+      message: Everything looks fine.
+      info: Any issues will show up here as you edit.
+    almost_junction:
+      message: "{feature} is very close but not connected to {feature2}"
+      highway-highway:
+        tip: Intersecting highways should share a junction vertex.
+    crossing_ways:
+      message: "{feature} crosses {feature2}"
+      building-building:
+        tip: "Buildings should not intersect except on different layers."
+      building-highway:
+        tip: "Highways crossing buildings should use bridges, tunnels, coverings, or entrances."
+      building-railway:
+        tip: "Railways crossing buildings should use bridges or tunnels."
+      building-waterway:
+        tip: "Waterways crossing buildings should use tunnels or different layers."
+      highway-highway:
+        tip: "Crossing highways should use bridges, tunnels, or intersections."
+      highway-railway:
+        tip: "Highways crossing railways should use bridges, tunnels, or level crossings."
+      highway-waterway:
+        tip: "Highways crossing waterways should use bridges, tunnels, or fords."
+      railway-railway:
+        tip: "Crossing railways should be connected or use bridges or tunnels."
+      railway-waterway:
+        tip: "Railways crossing waterways should use bridges or tunnels."
+      waterway-waterway:
+        tip: "Crossing waterways should be connected or use tunnels."
+      tunnel-tunnel:
+        tip: "Crossing tunnels should use different layers."
+      tunnel-tunnel_connectable:
+        tip: "Crossing tunnels should be connected or use different layers."
+      bridge-bridge:
+        tip: "Crossing bridges should use different layers."
+      bridge-bridge_connectable:
+        tip: "Crossing bridges should be connected or use different layers."
+    deprecated_tag:
+      message: '{feature} has outdated tags: {tags}'
+      tip: "Some tags become deprecated over time and should be replaced."
+    disconnected_way:
+      highway:
+        message: "{highway} is disconnected from other roads and paths"
+        tip: "Highways should connect to other highways or building entrances."
+    generic_name:
+      message: '{feature} has the generic name "{name}"'
+      tip: "Names should be the official, on-the-ground titles of features."
+    many_deletions:
+      points-lines-areas:
+        message: "Deleting {n} features: {p} points, {l} lines, and {a} areas"
+      points-lines-areas-relations:
+        message: "Deleting {n} features: {p} points, {l} lines, {a} areas, and {r} relations"
+      tip: "Only redundant or nonexistent features should be deleted."
+    missing_tag:
+      any:
+        message: "{feature} has no tags"
+      descriptive:
+        message: "{feature} has no descriptive tags"
+      specific:
+        message: '{feature} has no "{tag}" tag'
+      tip: "Features must have tags that define what they are."
+    old_multipolygon:
+      message: "{multipolygon} has misplaced tags"
+      tip: "Multipolygons should be tagged on their relation, not their outer way."
+    tag_suggests_area:
+      message: "{feature} should be a closed area based on the tag: {tag}"
+      tip: "Areas must have connected endpoints."
+    fix:
+      add_connection_vertex:
+        title: Connect the features
+        annotation: Connected crossing features.
+      connect_almost_junction:
+        title: Connect the features
+        annotation: Connected very close features.
+      continue_from_start:
+        title: Continue drawing from start
+      continue_from_end:
+        title: Continue drawing from end
+      delete_feature:
+        title: Delete this feature
+      connect_endpoints:
+        title: Connect the ends
+        annotation: Connected the endpoints of a way.
+      move_tags:
+        title: Move the tags
+        annotation: Moved tags.
+      remove_generic_name:
+        title: Remove the name
+        annotation: Removed a generic name.
+      remove_tag:
+        title: Remove the tag
+        annotation: Removed tag.
+      select_preset:
+        title: Select a feature type
+      tag_as_disconnected:
+        title: Tag as disconnected
+        annotation: Tagged very close features as disconnected.
+      upgrade_tags:
+        title: Upgrade tags
+        annotation: Upgraded tags.
   intro:
     done: done
     ok: OK
@@ -1548,4 +1640,4 @@ en:
   wikidata:
     identifier: "Identifier"
     label: "Label"
-    description: "Description"
+    description: "Description"