Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicify grid for save area of notes and keepright. #5695

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Nicify grid for save area of notes and keepright. #5695

merged 1 commit into from
Jan 11, 2019

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Jan 11, 2019

(A place with note and keepright nearby to test it.)

This is a detail for #5679.

For keepright I feel like the grid is off.
For notes its the same but less visible due to the comments area.

IMO the save are should be part of the outer "box", so no padding left and right, to fit in the information hierarchy.

keepright before
keepright-before

keepright after
keepright-after

note before
notes-before

notes after
notes-after

ps: I did not run this locally, just edited the one file in github, so probably some steps to take …

Nicify grid for save area of notes and keepright.
@bhousel
Copy link
Member

bhousel commented Jan 11, 2019

Thanks this was bothering me too..

Now the headings don't line up, but I think I'll just remove the "Description" heading because we don't need it.

Part of the issue here is that we have several components can now render into the sidebar, and they've been build inconsistently (as far as whether they use padding/margin or block/flex for layout of subsections). I kind of want to change more, but this is ok for now.

@bhousel bhousel merged commit 75c1448 into openstreetmap:master Jan 11, 2019
@tordans tordans deleted the patch-5 branch January 12, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants