Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transit presets for Public Transport v2 schema #4585

Merged
merged 5 commits into from
Dec 5, 2017
Merged

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Dec 2, 2017

(closes #3041)
(closes #3508)
(closes #4566)

This updates all of the transit-related presets to use the Public Transport v2 Schema

Generally what I did was:

  • make a bunch of legacy presets non-searchable (existing features will still be recognized by iD, but new features will get both the legacy and the PTv2 tags).
  • add new presets under data/presets/public_transport/ which include the public_transport=* tags and also set the legacy tags too.
  • add good search terms for everything and update the names of the presets to try to guide users to do the right thing
  • make sure that the reference documentation points to the best page (often that's the legacy one).

I still have to test this a bunch, but hope to merge soonish so that translators can get to work 👍

This is done so that the linear presets can have an icon that looks
more like a footway/sidewalk, to encourage people to use them that way
and connect them to the pedestrian network.
@bhousel
Copy link
Member Author

bhousel commented Dec 3, 2017

This is mostly ok.. I'm going to make a few icon tweaks to make sure that all of the different supported transport modes have a good icon. Maki contains good ones for bus, rail, light-rail, subway(metro), aerialway, ferry. The internal iD-sprite has a few others, but might be line only: monorail and maybe some others.

  • Make sure all the icons are consistent (we have a mix of new maki for poi, and old maki for lines)
  • Do something better for tram/light_rail? (trams have tracks in a road, light-rail is a mostly separated system)
  • Do something for trolleybus (electric rubber-tire bus powered by overheard caternary wires, even just the bus icon with something above it would help)
  • See if the monorail line icon in the iD-spritesheet can be used for poi features (without the line)
  • See if we can better differentiate between platform (where people wait) and stop_position (where vehicle stops). I've talked to normal people about this and they hate it. This part of PTv2 is weird and non-intuitive, but we should try.

Consistency and better coverage is important so that people using the presets will know what they are for and map correctly.

@bhousel
Copy link
Member Author

bhousel commented Dec 5, 2017

Ok I think I have the icons all sorted out - I'm pretty happy with them!

screenshot 2017-12-05 00 18 04screenshot 2017-12-05 00 22 03

@bhousel bhousel merged commit a8d0aae into master Dec 5, 2017
@bhousel bhousel deleted the pt_v2 branch December 5, 2017 05:36
@nlehuby
Copy link
Contributor

nlehuby commented Dec 5, 2017 via email

@bhousel
Copy link
Member Author

bhousel commented Dec 5, 2017

When will it be available in osm.org ?

1 or 2 weeks - I need to give a chance for the translators to catch up, and they already have a lot of work to do on the new Help text. I'll send out some reminders on twitter and mailing lists that we could use help..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mark public_transport=station as bus station Improve public_transport tagging
2 participants