Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue to upload assets job even if npm publish step fails #1638

Merged
merged 12 commits into from
Mar 4, 2025
Merged

fix: continue to upload assets job even if npm publish step fails #1638

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
689d004
fix error: TypeError: event.target.closest(...) is null
Nov 15, 2024
bb17297
Merge branch 'main' into bugfix/fix-broken-help-page
salvar3nga Nov 15, 2024
d4376a3
refactoring
Nov 15, 2024
291dbf6
fix failing test
Nov 18, 2024
a0c86a0
refactorings
Nov 18, 2024
5ec582d
reinstate deleted Fn
Nov 18, 2024
22199f9
Merge branch 'openscd:main' into main
salvar3nga Feb 12, 2025
308f4a7
Merge branch 'openscd:main' into main
salvar3nga Feb 17, 2025
001b9f1
Merge branch 'openscd:main' into main
salvar3nga Feb 18, 2025
a256520
Merge branch 'openscd:main' into main
salvar3nga Feb 27, 2025
24280a3
Merge branch 'openscd:main' into main
salvar3nga Mar 4, 2025
7a572f6
fix: continue upload job even if npm publish fails
Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactorings
  • Loading branch information
Sergio Alvarenga committed Nov 18, 2024
commit a0c86a0dd068fe46bb9592a2d0a03dd8b5d41bf8
6 changes: 3 additions & 3 deletions packages/plugins/src/menu/Help.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { openSCDIcon } from '@openscd/open-scd/src/icons/icons.js';
import { Directory } from '@openscd/open-scd/src/finder-list.js';

const GITHUB_WIKI_LINK_PATTERN = /https:\/\/github\.com\/openscd\/open-scd\/wiki\/([^)]*)/g;
const MD_LINK_TITLE_PATTERN =/[^\\]]*/;
const MD_LINK_TITLE_PATTERN ='([^\\]]*)';
const HYPHEN_PATTERN = /-/g;

function aboutBox(version: string) {
Expand Down Expand Up @@ -49,9 +49,9 @@ async function getLinkedPages(path: string[]): Promise<Directory> {
const page = path[path.length - 1].replace(/ /g, '-');
const res = await fetch(`/openscd/public/md/${page}.md`);
const md = await res.text();
const MD_LINK_REPLACEMENT = `<a style="cursor: help; color: var(--mdc-theme-primary)" href="https://github.com/openscd/open-scd/wiki/$2" target="_blank">$1</a>`
const MD_LINK_REPLACEMENT = `<a style="cursor: help; color: var(--mdc-theme-primary)" href="https://github.com/openscd/open-scd/wiki/$2" target="_blank" >$1</a>`
const unlinkedMd = md.replace(
new RegExp(`\\[(${MD_LINK_TITLE_PATTERN.source})\\]\\(${GITHUB_WIKI_LINK_PATTERN.source}\\)`, 'g'),
new RegExp(`\\[${MD_LINK_TITLE_PATTERN}\\]\\(${GITHUB_WIKI_LINK_PATTERN.source}\\)`, 'g'),
MD_LINK_REPLACEMENT
);

Expand Down