Integrate Wizarding API V3 from OpenEnergyTools to OpenSCD #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senzacionale
force-pushed
the
feat/wizarding-v3
branch
2 times, most recently
from
f21f485 to
e2bb55b
Compare
senzacionale
force-pushed
the
feat/wizarding-v3
branch
from
c4d34cb to
47237da
Compare
|
@david-monichi is this one ready to review? |
trusz
approved these changes
Mar 12, 2025
Comment on lines
+92
to
+95
| this.updateComplete | ||
| .then(() => this.wizardUI.updateComplete) | ||
| .then(() => this.wizardUI.dialog?.updateComplete) | ||
| .then(() => this.wizardUI.dialog?.focus()); |
There was a problem hiding this comment.
Thank you for the small cleanups too :)
Comment on lines
+101
to
+110
| this.addEventListener('wizard', this.onWizard as EventListener); | ||
| this.addEventListener('oscd-edit-wizard-request', (e: Event) => | ||
| this.onWizardRequest(e as CustomEvent<EditWizardRequest>) | ||
| ); | ||
| this.addEventListener('oscd-create-wizard-request', (e: Event) => | ||
| this.onWizardRequest(e as CustomEvent<CreateWizardRequest>) | ||
| ); | ||
| this.addEventListener('oscd-close-wizard', () => this.onCloseWizard()); | ||
| this.addEventListener('editor-action', () => | ||
| this.wizardUI.requestUpdate() | ||
| this.wizardUI?.requestUpdate() |
There was a problem hiding this comment.
couldn't we put the event listener on the HTML elements?
something along these lines:
render(): TemplateResult {
return html`
${ifImplemented(super.render())}
<wizard-dialog
.wizard=${this.workflow[0]?.() ?? []}
@oscd-edit-wizard-request=${this.onWizardRequest}
@oscd-close-wizard=${this.onCloseWizard}
>
</wizard-dialog>
`;
}This way Litjs can handle their lifecycle.
There was a problem hiding this comment.
I think it's possible. I'll test it and make the change.
| } else if (wizard === null) { | ||
| this.workflow.shift(); | ||
| } else if (wizard) { | ||
| subwizard ? this.workflow.unshift(wizard) : this.workflow.push(wizard); |
There was a problem hiding this comment.
is there a reason why it is not just another 'if-else'?
There was a problem hiding this comment.
No special reason. I will change it.
Comment on lines
+95
to
+98
| this.updateComplete | ||
| .then(() => this.wizardUI.updateComplete) | ||
| .then(() => this.wizardUI.dialog?.updateComplete) | ||
| .then(() => this.wizardUI.dialog?.focus()); |
There was a problem hiding this comment.
again, thank you for the clean up :)
|
I see the deployment has not been tested. I'll try it locally first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate Wizarding API V3 from OpenEnergyTools to OpenSCD
As external project the PR can't be marked as draft.