-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 #1722
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
Webrevs
|
Reviewers: @kevinrushforth @tiainen or @johanvos /reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple (minor) questions, but the changes look good to me. I'll test it early next week.
WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the crash fix is related to Skia CPU rendering which does not apply to JavaFX Webkit.
This patch has been tested on Jenkins and there is no side effects introduced.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1722/head:pull/1722
$ git checkout pull/1722
Update a local copy of the PR:
$ git checkout pull/1722
$ git pull https://git.openjdk.org/jfx.git pull/1722/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1722
View PR using the GUI difftool:
$ git pr show -t 1722
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1722.diff
Using Webrev
Link to Webrev Comment