Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 #1722

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Feb 22, 2025

WebkitGTK 2.46.6 has additional fixes for crash and rendering issue, the crash fix is related to Skia CPU rendering which does not apply to JavaFX Webkit.
This patch has been tested on Jenkins and there is no side effects introduced.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8349924: Additional WebKit 620.1 fixes from WebKitGTK 2.46.6 (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1722/head:pull/1722
$ git checkout pull/1722

Update a local copy of the PR:
$ git checkout pull/1722
$ git pull https://git.openjdk.org/jfx.git pull/1722/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1722

View PR using the GUI difftool:
$ git pr show -t 1722

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1722.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 22, 2025

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 22, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Feb 22, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 22, 2025

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen or @johanvos

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review February 22, 2025 13:45
@openjdk
Copy link

openjdk bot commented Feb 22, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple (minor) questions, but the changes look good to me. I'll test it early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants