Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaFX Preview Features #1700

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Feb 7, 2025

This PR contains a proposal for JavaFX Preview Features.

This PR is illustrative in nature. It will remain in Draft and will never be made rfr. It includes the following:

  1. The JavaFX Preview Features JEP and implementation notes.
  2. Two sample preview features: PreviewFeature.MY_SAMPLE_FEATURE_1 and PreviewFeature.MY_SAMPLE_FEATURE_2, along with the preview APIs javafx.application.MyPreviewFeature, Platform.getMyPreviewFeature1(), and Platform.getMyPreviewFeature2().

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1700/head:pull/1700
$ git checkout pull/1700

Update a local copy of the PR:
$ git checkout pull/1700
$ git pull https://git.openjdk.org/jfx.git pull/1700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1700

View PR using the GUI difftool:
$ git pr show -t 1700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1700.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 7, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant