8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup

[Maran23]

This PR improves the Tree-/TableRowSkin code by doing a normal live lookup for the fixedCellSize instead of adding listener just to update variables(fixedCellSizeEnabled and fixedCellSize) which can otherwise be also just lookup'd without the hassle of listeners.

While this is mostly a cleanup, it does improve the state of the Tree-/TableRow, as when the TableRowSkinBase constructor is called, the variables are not yet set.

It is also consistent with the other cells, see also JDK-8246745.
Helps a bit with JDK-8185887 (#1644), but as written above, not required as there is no (visible) effect.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup (Bug - P4)

Reviewers

• Andy Goryachev (@andy-goryachev-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1645/head:pull/1645
$ git checkout pull/1645

Update a local copy of the PR:
$ git checkout pull/1645
$ git pull https://git.openjdk.org/jfx.git pull/1645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1645

View PR using the GUI difftool:
$ git pr show -t 1645

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1645.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[Maran23]

Since #1635 got merged, this is not needed as TableRowSkinBase does that already:
registerChangeListener(control.indexProperty(), e -> requestCellUpdate());. So this is basically a noop.

[mlbridge]

Webrevs

• 04: Full - Incremental (bb79066a)
• 03: Full - Incremental (9b12fbf7)
• 02: Full (e6595b8f)
• 01: Full - Incremental (5d5c0c3b)
• 00: Full (8206f821)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[andy-goryachev-oracle]

Tested with the Monkey Tester, both TreeTableView and TableView - looks good, responds to fixed cell size changes.

Left a few minor comments.

[bridgekeeper]

@Maran23 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@Maran23 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[andy-goryachev-oracle]

Now that #1644 has been merged, should this PR be re-opened?

[Maran23]

/open

Now that #1644 has been merged, should this PR be re-opened?

Yes! I wanted to check everything first before I reopen it. Should be good now.

[openjdk]

@Maran23 This pull request is now open

[andy-goryachev-oracle]

A good improvement!
The testing on macOS 15.3.1 M1 looks good.