Refactor connection handling for API 31+ #3817
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Danny Baumann <[email protected]>
Don't use the deprecated ConnectivityManager.getAllNetworks() method, and extract the current Wi-Fi SSID from the already present NetworkCapabilities object instead of querying it separately. Signed-off-by: Danny Baumann <[email protected]>
If the local server wasn't available (detection attempts timed out) last time the app was in foreground, without a connection update it will make no attempts to use the local connection when it's brought to foreground again, even though the local server might be available now. Signed-off-by: Danny Baumann <[email protected]>
maniac103
force-pushed
the
connection-refactor
branch
from
f6c36fa to
4c27ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use non-deprecated functions, and restart connection check in
MainActivity.onStart().