This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Verify sender's balance before importing transaction to queue #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomusdrw
commented
Mar 16, 2016
tomusdrw
commented
- Additional trace logging
|
Test fails |
|
Yes, sorry. Fixing it (after changing validation to include full transaction cost balance in test was insufficient). |
|
Could you please check that this does not affect the block propagation logic? It should not send out any blocks (and transactions) while the sync is still active, and I believe this was done by not sending the chain changed event until the sync is complete. |
arkpar
added
A5-grumble 🔥
|
ditto. also, right now the client and sync logic is extremely brittle. please place plentiful comments/documentation around any logic changed. |
| let import = miner.import_transactions(vec![signed_transaction], |a: &Address| client.nonce(a)); | ||
| let import = miner.import_transactions(vec![signed_transaction], |a: &Address| AccountDetails { | ||
| nonce: client.nonce(a), | ||
| balance: client.balance(a) |
tomusdrw
changed the title
|
After chat with @arkpar I've removed the change in client (it should be in separate pr anyway). |
tomusdrw
added
A0-pleasereview 🤓
gavofyork
added
A8-looksgood 🦄
|
ok - lgtm then. |
gavofyork
added a commit
that referenced
this pull request
Mar 17, 2016
Verify sender's balance before importing transaction to queue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.