dev feature enabled when compiling without --release

[tomusdrw]

No description provided.

[arkpar]

@NikVolf Is this a dev dependency as well?

[tomusdrw]

I think that it isn't. It should still be used when you run cargo test --release

[tomusdrw]

This is the best I came up with.

1. Clippy dependency is optional (and has to be because it's not possible to compile clippy on stable/beta).
2. When compiling on nightly for development (without --release flag) the build will fail because of missing clippy create.
3. You have to explicitly invoke cargo test --features dev-clippy when building without --release on nightly.
4. It's not possible to add dependency or to enable feature from build.rs

[debris]

I think, it should be dev-clippy instead of clippy.

[gavofyork]

does this address the problem properly?

[tomusdrw]

It just forces you to use --feature dev-clippy when compiling on nightly without --release. I'm not sure if that's the correct way to address the problem.

There is also a convenience script included to run something like ./cargo.sh test -p ethcore (it adds the feature for you).