This repository was archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Merged
WASM contracts MVP #5679
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
d8cc649
lifetime issues
NikVolf 36f51d6
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 1632387
refactor to new 'native env'
NikVolf d3c0e85
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf af5a4b4
descriptors and such
NikVolf 9a8c3c3
wasm mvp continued
NikVolf 7dced88
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf ee07e77
finalized env/ext bindings
NikVolf fcbd5bc
descriptor -> call_args
NikVolf d9c026c
inject gas counter
NikVolf a952b56
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf b073836
result processing and engine activation
NikVolf 7c7c5b1
tabify some source files
NikVolf 5b2aac6
Merge branch 'master' into wasm-mvp
NikVolf 0546281
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf fe18e14
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 340b2fa
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf b39552d
needs return new
NikVolf 0b8d0b4
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 34ad213
wasm tests initial
NikVolf 290347e
erradicate warnings
NikVolf f7a8959
origin in the descriptor
NikVolf 74cbc2f
Merge branch 'master' of github.com:paritytech/parity into wasm-mvp
NikVolf 5f9056d
update test repo
NikVolf e80a75b
payload verification tests
NikVolf 5edcaf3
identity return payload test
NikVolf a7c3e21
some test description
NikVolf e86ee04
dispersion test
NikVolf b3f3c76
check length here
NikVolf 4596611
suicidal contract
NikVolf 6ba30e1
engine params
NikVolf f0d5221
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf b871211
fix typo
NikVolf 0842aa8
review fixes
NikVolf 1258adc
submodule update
NikVolf 29ef219
update - purge reserved space
NikVolf 00dd894
doc effort
NikVolf 223833b
more review fixes
NikVolf e3bb056
fix error message
NikVolf f3cd650
fix dependency url
NikVolf e12f7cb
reorg error handling
NikVolf c921e6e
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 7b261e3
update submodule
NikVolf e90a0d3
update utils
NikVolf 15befc5
update to latest parity-wasm
NikVolf 16c4916
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf ff871a9
tabify
NikVolf 6c0b165
fix wasm magic header
NikVolf eaedb48
update dependencies
NikVolf 615691c
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 07696d2
external create and tests
NikVolf 165ffc0
update to latest tests
NikVolf efbc251
extra trace info
NikVolf af6b62f
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 2f0cd97
Update parity-wasm
NikVolf e6a1fd7
update wasm-utils also
NikVolf 201a115
merge and update
NikVolf 9222708
few traces and result handle change
NikVolf f514444
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf d873433
alter trace content
NikVolf 6ca80c4
fix issues with optimizer, update to latest parity with validator, etc
NikVolf b45c451
static initialization
NikVolf 7811663
license preamble
NikVolf 540bd6a
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf ce97dcf
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 3b96f08
update wasm crates and gas costs
NikVolf 59c5da4
Merge remote-tracking branch 'origin/master' into wasm-mvp
NikVolf 397fb7b
fix grumbles
NikVolf 1731787
bring back lifetime
NikVolf 7dadc9f
fix compilation
NikVolf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule wasm-tests
added at
9ed630
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something better we can give here than
String
? Maybe aWasmError
enum with some number of "proper" error variants and oneUnknown(String)
variant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid to wrap
parity_wasm::interpreter::Error
, because it cannot be later meaningfully encoded as trace error and put in trace db, that's why it's encoded as stringAlso I cannot imagine any code that would rely on handling specific wasm interpreter errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it's strictly for human-readable messages then that's fine. If we ever finding ourself matching on it we can refactor to make it an enum.