cache manager and clearing tracing cache #1769

debris · 2016-07-29T11:52:39Z

right now max_cache_size is set to 20 mb. In next pr I will make it configurable from cli

coveralls · 2016-07-29T13:45:40Z

Coverage increased (+0.05%) to 86.874% when pulling 0674b68 on cache_man into 29e0775 on master.

rphmeier · 2016-07-30T11:13:09Z

ethcore/src/cache_manager.rs

+		}
+	}
+
+	pub fn collect_carbage<C, F>(&mut self, current_size: C, mut notify_unused: F) where C: Fn() -> usize, F: FnMut(HashSet<T>) {


carbage -> garbage

coveralls · 2016-07-30T12:00:55Z

Coverage increased (+0.07%) to 86.915% when pulling a8cc537 on cache_man into 57faa37 on master.

gavofyork · 2016-07-30T13:43:54Z

a test would be nice - i think there are already tests for the rest of the cache. can wait for the next
PR though, i guess.

debris added 5 commits July 29, 2016 11:23

removed configure_cache method

b7c98e2

generic cache_manager struct

0321cac

fixed #1743, tracing caches are cleared

2e23df1

removed deadlocks in garbage_collect, implemented HeapSizeOf for traces

c3c0926

trace cache config

0674b68

debris added the A0-pleasereview 🤓 Pull request needs code review. label Jul 29, 2016

rphmeier reviewed Jul 30, 2016
View reviewed changes

debris added 2 commits July 30, 2016 13:27

Merge branch 'master' of github.com:ethcore/parity into cache_man

28b85d1

fixed carbage typo

a8cc537

gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 30, 2016

gavofyork merged commit bcf8cd6 into master Jul 30, 2016

gavofyork deleted the cache_man branch July 30, 2016 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cache manager and clearing tracing cache #1769

cache manager and clearing tracing cache #1769

debris commented Jul 29, 2016

coveralls commented Jul 29, 2016 •

edited

Loading

rphmeier Jul 30, 2016

coveralls commented Jul 30, 2016 •

edited

Loading

gavofyork commented Jul 30, 2016 •

edited

Loading

cache manager and clearing tracing cache #1769

cache manager and clearing tracing cache #1769

Conversation

debris commented Jul 29, 2016

coveralls commented Jul 29, 2016 • edited Loading

rphmeier Jul 30, 2016

Choose a reason for hiding this comment

coveralls commented Jul 30, 2016 • edited Loading

gavofyork commented Jul 30, 2016 • edited Loading

coveralls commented Jul 29, 2016 •

edited

Loading

coveralls commented Jul 30, 2016 •

edited

Loading

gavofyork commented Jul 30, 2016 •

edited

Loading