Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

IPC RPC deriving for traits #1599

Merged
merged 3 commits into from
Jul 14, 2016
Merged

IPC RPC deriving for traits #1599

merged 3 commits into from
Jul 14, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jul 12, 2016

#[derive(Ipc)]
trait DBNotify {
    fn notify(&self, a: u64, b: u64) -> bool;
}

so that above become possible

needed for pub/sub IPC scenarios

goes after #1584

@NikVolf NikVolf added the A0-pleasereview 🤓 Pull request needs code review. label Jul 12, 2016
@NikVolf NikVolf closed this Jul 12, 2016
@NikVolf NikVolf reopened this Jul 12, 2016
@NikVolf NikVolf closed this Jul 12, 2016
@NikVolf NikVolf reopened this Jul 12, 2016
@NikVolf NikVolf closed this Jul 13, 2016
@NikVolf NikVolf reopened this Jul 13, 2016
@rphmeier
Copy link
Contributor

travis failure is legitimate

@tomusdrw tomusdrw closed this Jul 14, 2016
@tomusdrw tomusdrw reopened this Jul 14, 2016
@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Changes Unknown when pulling c33788f on ipc-trait-interface into * on master*.

@gavofyork
Copy link
Contributor

needs resolving.

@NikVolf NikVolf force-pushed the ipc-trait-interface branch from c33788f to f380340 Compare July 14, 2016 10:31
@NikVolf
Copy link
Contributor Author

NikVolf commented Jul 14, 2016

@gavofyork rebasing? - done
though i had to resolve the same conflicts twice because of the commits squashing again

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 14, 2016
@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage increased (+0.02%) to 76.644% when pulling c60e02d on ipc-trait-interface into 6c20506 on master.

@gavofyork gavofyork merged commit be7c771 into master Jul 14, 2016
@gavofyork gavofyork deleted the ipc-trait-interface branch July 14, 2016 12:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants