feat(instrument-mongoose-7): Added instrumentation package for mongoose v7 (#1606) #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Support was added in #2353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1606
Short description of the changes
Following the comment in the issue by pichlermarc creating a new package for Mongoose v7 was the easiest path forward for me, given the significant, non backwards compatible changes introduced by removing callbacks.
instrument-mongoose-7package torelease-please-config.json.removeandupdatemethods that were deprecated in Mongoose v6 and removed in Mongoose v7.findOneAndUpdate, which appears to generate only a single span now.Honestly, I mostly just removed callbacks, nonexistent functions, and unnecessary tests. Remaining tests pass and everything seems to build without error.