Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(exporterhelper): Add exporterhelper timeout policy support #11385

Closed
wants to merge 7 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Oct 7, 2024

Description

Second half of #11183.

Existing behavior is unchanged which is to sustain the short timeout, let it succeed if possible.

Alternative behaviors:

  • "ignore": Ignore the short timeout, use the configured timeout
  • "abort": Abort the request, since there is a chance the client will abort before we return.

Note: depends on #11387, has to be rebased. See also draft/discussion in #11198.

Link to tracking issue

Fixes #11183

Testing

New tests for 3 policy variations and that default is unchanged.

Documentation

@jmacd jmacd marked this pull request as ready for review October 7, 2024 19:59
@jmacd jmacd requested a review from a team as a code owner October 7, 2024 19:59
@jmacd jmacd requested a review from evan-bradley October 7, 2024 19:59
@jmacd
Copy link
Contributor Author

jmacd commented Oct 7, 2024

This is a complete PR, so I am opening it for review.

However, I've added a new package config/configtimeout and it appears to break things if I try to add a new package and use it in the same PR (or same release). Therefore, I'm looking for feedback on the PR while in parallel, I'll send the new configtimeout package as a stand-alone PR.

@jmacd jmacd changed the title Add exporterhelper timeout policy support (timeout sender): Add exporterhelper timeout policy support Oct 7, 2024
@jmacd jmacd changed the title (timeout sender): Add exporterhelper timeout policy support (exporterhelper): Add exporterhelper timeout policy support Oct 7, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 22, 2024
@jmacd
Copy link
Contributor Author

jmacd commented Oct 30, 2024

I am working on an RFC for this.

@jmacd jmacd closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporterhelper does not respect context deadlines
1 participant