(exporterhelper) Retry sender: fail request if context timeout < next retry #11331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11331 +/- ##
=======================================
Coverage 91.50% 91.51%
=======================================
Files 430 430
Lines 20209 20228 +19
=======================================
+ Hits 18493 18511 +18
- Misses 1341 1342 +1
Partials 375 375 ☔ View full report in Codecov by Sentry. |
bogdandrutu
approved these changes
Oct 5, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
… retry (open-telemetry#11331) #### Description The retry sender will delay until the context is canceled, where instead it could fail fast with a transient error and a clear message that no more retries are possible given the configuration. #### Link to tracking issue Part of open-telemetry#11183 #### Testing One new test.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
… retry (open-telemetry#11331) #### Description The retry sender will delay until the context is canceled, where instead it could fail fast with a transient error and a clear message that no more retries are possible given the configuration. #### Link to tracking issue Part of open-telemetry#11183 #### Testing One new test.
|
I think apart from comparing deadline from context with backoff delay, we should also compare max elapsed time with it? and one problem with context deadline is that it is not set properly in the collector, f.e. timeout sender is the next sender of retry sender, but it sets its own context with deadline, not the same context retry sending uses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The retry sender will delay until the context is canceled, where instead it could fail fast with a transient error and a clear message that no more retries are possible given the configuration.
Link to tracking issue
Part of #11183
Testing
One new test.