Header Setter Extension: add default value to configuration #34455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* default value config * set default value in context source if metadata empty fixes open-telemetry#34412
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@f7o , is this ready for review? |
|
@jpkrohling implementing tests is still pending, will do soon. |
f7o
force-pushed
the
header-setter-default-value
branch
from
87cbf6b to
31c936d
Compare
|
@jpkrohling ready for review |
jpkrohling
approved these changes
Sep 9, 2024
f7o
force-pushed
the
header-setter-default-value
branch
from
31c936d to
b7ed7e3
Compare
|
@Frapschen @jpkrohling who will/can merge this? I am not sure on all these checks, some seem broken, not able to pull changes, ... |
|
I'll merge once the CI is green |
|
please add a changelog |
|
@jpkrohling added a changelog CI doesn't seem to work!? workflows are pending or only running certain times? |
f7o
force-pushed
the
header-setter-default-value
branch
from
c12237b to
bbb5b43
Compare
f7o
requested review from
djaglowski,
MovieStoreGuy,
andrzej-stencel,
crobert-1,
dashpole and
atoulme
as code owners
f7o
requested review from
jmacd,
dmitryax,
codeboten,
fatsheep9146,
TylerHelmuth,
yurishkuro,
mx-psi,
bogdandrutu,
evan-bradley,
tigrannajaryan,
mwear,
jsuereth,
songy23 and
bryan-aguilar
as code owners
f7o
force-pushed
the
header-setter-default-value
branch
2 times, most recently
from
5e1d72d to
87cbf6b
Compare
This was referenced Sep 18, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…emetry#34455) **Description:** <Describe what has changed.> * default value config * set default value in context source if metadata empty **Link to tracking Issue: open-telemetry#34412 **Testing:** tbd **Documentation:** see README.md --------- Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
**Link to tracking Issue: #34412
Testing: tbd
Documentation: see README.md