Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: humble fixes #624

Closed
wants to merge 38 commits into from
Closed

deps: humble fixes #624

wants to merge 38 commits into from

Conversation

koonpeng
Copy link
Collaborator

@koonpeng koonpeng commented Jun 28, 2022

What's new

This updates the pipfile to use python 3.10, the consequences of this is that it will no longer work on ubuntu 20.04. pipenv does not support python version ranges so we can't support both versions at the same time.

Other alternatives workarounds:

  • Remove the python version check, this will allow it to work for both ubuntu 20.04 and 22.04, but the issue with this is that pipenv will just use whatever python version it can find. This means that the resolution of dependencies will be different depending on the environment and since deps are locked into pipfile.lock and committed into git, it can create many many problems.

The only way I can think of that works for both ubuntu 20.04 and 22.04 is to maintain multiple branches. If we want to continue supporting galactic and below, we can branch off the current main and have main only support humble.

This is built on top of #623.
Requires open-rmf/rmf#165.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

Teo Koon Peng added 25 commits June 14, 2022 14:13
Signed-off-by: Teo Koon Peng <[email protected]>
…dow manager in dashboard

Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng requested a review from aaronchongth June 28, 2022 07:31
@koonpeng koonpeng changed the base branch from main to feat/window-system-v2 June 28, 2022 07:34
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #624 (092ef94) into feat/window-system-v2 (63d2169) will not change coverage.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           feat/window-system-v2     #624   +/-   ##
======================================================
  Coverage                  63.56%   63.56%           
======================================================
  Files                        321      321           
  Lines                       6198     6198           
  Branches                     713      713           
======================================================
  Hits                        3940     3940           
  Misses                      2105     2105           
  Partials                     153      153           
Flag Coverage Δ
react-components 60.46% <ø> (ø)
rmf-auth ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/api-server/api_server/fast_io/__init__.py 77.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d2169...092ef94. Read the comment docs.

Teo Koon Peng added 9 commits July 6, 2022 02:22
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
This reverts commit 7892953627fb3f0d804a949a6db1f8be2a01e720.
Signed-off-by: Teo Koon Peng <[email protected]>
Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng force-pushed the deps/humble-fixes branch from bbd4097 to 9a5ccc0 Compare July 6, 2022 02:22
Teo Koon Peng added 3 commits July 6, 2022 02:31
Signed-off-by: Teo Koon Peng <[email protected]>
@koonpeng koonpeng mentioned this pull request Jul 7, 2022
5 tasks
Base automatically changed from feat/window-system-v2 to main July 13, 2022 09:56
@koonpeng
Copy link
Collaborator Author

closed in favor of #628

@koonpeng koonpeng closed this Aug 31, 2022
@aaronchongth aaronchongth deleted the deps/humble-fixes branch September 27, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant