Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nx packages #1147

Merged
merged 18 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nx"],
"extends": [
"eslint:recommended",
"plugin:prettier/recommended"
],
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"overrides": [
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
Expand All @@ -28,17 +25,41 @@
{
"files": ["*.ts", "*.tsx"],
"extends": ["plugin:@nx/typescript"],
"rules": {}
"rules": {
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
"rules": {
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": "*.json",
"parser": "jsonc-eslint-parser",
"rules": {}
},
{
"files": ["*.json"],
"parser": "jsonc-eslint-parser",
"rules": {
"@nx/dependency-checks": [
"error",
{
"buildTargets": ["lint"],
"includeTransitiveDependencies": false,
"checkMissingDependencies": true,
"checkObsoleteDependencies": true,
"checkVersionMismatches": true,
"ignoredDependencies": ["jest-cucumber", "jest"],
"ignoredFiles": ["**/*.spec.ts", "**/*.spec.js", "**/*.test.ts", "**/*.test.js"]
}
]
}
}
]
}
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
# This line is needed for nx affected to work when CI is running on a PR
- run: git branch --track main origin/main || true

- run: npx nx workspace-lint
- run: if ! npx nx format:check ; then echo "Format check failed. Please run 'npx nx format:write'."; fi
- run: npx nx affected --target=lint --parallel=3
- run: npx nx affected --target=test --parallel=3 --ci --code-coverage
Expand Down
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@

/dist
/coverage

/.nx/cache
/.nx/workspace-data
8 changes: 4 additions & 4 deletions jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getJestProjects } from '@nx/jest';
import { getJestProjectsAsync } from '@nx/jest';

export default {
projects: getJestProjects(),
};
export default async () => ({
projects: await getJestProjectsAsync(),
});
2 changes: 1 addition & 1 deletion libs/hooks/open-telemetry/babel.config.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"presets": [["minify", { "builtIns": false }]]
}
}
6 changes: 3 additions & 3 deletions libs/hooks/open-telemetry/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@openfeature/open-telemetry-hooks",
"version": "0.4.0",
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "https://github.com/open-feature/js-sdk-contrib.git",
Expand All @@ -16,6 +17,5 @@
"peerDependencies": {
"@openfeature/server-sdk": "^1.13.0",
"@opentelemetry/api": ">=1.3.0"
},
"license": "Apache-2.0"
}
}
}
37 changes: 8 additions & 29 deletions libs/hooks/open-telemetry/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
"targets": {
"package": {
"executor": "@nx/rollup:rollup",
"outputs": [
"{options.outputPath}"
],
"outputs": ["{options.outputPath}"],
"options": {
"project": "libs/hooks/open-telemetry/package.json",
"outputPath": "dist/libs/hooks/open-telemetry",
Expand All @@ -18,10 +16,7 @@
"generateExportsField": true,
"umdName": "OpenTelemetry",
"external": "all",
"format": [
"cjs",
"esm"
],
"format": ["cjs", "esm"],
"assets": [
{
"glob": "package.json",
Expand All @@ -38,23 +33,17 @@
"input": "./libs/hooks/open-telemetry",
"output": "./"
}
],
"updateBuildableProjectDepsInPackageJson": true
]
}
},
"build": {
"executor": "@nx/js:tsc",
"outputs": [
"{options.outputPath}"
],
"outputs": ["{options.outputPath}"],
"options": {
"outputPath": "dist/libs/hooks/open-telemetry",
"main": "libs/hooks/open-telemetry/src/index.ts",
"tsConfig": "libs/hooks/open-telemetry/tsconfig.lib.json",
"assets": [
"libs/hooks/open-telemetry/*.md"
],
"updateBuildableProjectDepsInPackageJson": true
"assets": ["libs/hooks/open-telemetry/*.md"]
}
},
"publish": {
Expand All @@ -70,24 +59,14 @@
]
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": [
"libs/hooks/open-telemetry/**/*.ts"
]
}
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
},
"test": {
"executor": "@nx/jest:jest",
"outputs": [
"{workspaceRoot}/coverage/libs/hooks/open-telemetry"
],
"outputs": ["{workspaceRoot}/coverage/libs/hooks/open-telemetry"],
"options": {
"jestConfig": "libs/hooks/open-telemetry/jest.config.ts",
"passWithNoTests": true,
"codeCoverage": true,
"coverageDirectory": "coverage/libs/hooks/open-telemetry"
}
Expand Down
4 changes: 3 additions & 1 deletion libs/providers/config-cat-web/package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
{
"name": "@openfeature/config-cat-web-provider",
"version": "0.1.3",
"license": "Apache-2.0",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/web-sdk": "^1.0.0",
"configcat-js-ssr": "^8.4.3"
"configcat-js-ssr": "^8.4.3",
"@openfeature/config-cat-core": "0.1.0"
}
}
37 changes: 7 additions & 30 deletions libs/providers/config-cat-web/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,37 +17,19 @@
]
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": [
"libs/providers/config-cat-web/**/*.ts"
]
}
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
},
"test": {
"executor": "@nx/jest:jest",
"outputs": [
"{workspaceRoot}/coverage/{projectRoot}"
],
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "libs/providers/config-cat-web/jest.config.ts",
"passWithNoTests": true
},
"configurations": {
"ci": {
"ci": true,
"codeCoverage": true
}
"jestConfig": "libs/providers/config-cat-web/jest.config.ts"
}
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": [
"{options.outputPath}"
],
"outputs": ["{options.outputPath}"],
"options": {
"project": "libs/providers/config-cat-web/package.json",
"outputPath": "dist/libs/providers/config-cat-web",
Expand All @@ -57,10 +39,7 @@
"generateExportsField": true,
"umdName": "config-cat",
"external": "all",
"format": [
"cjs",
"esm"
],
"format": ["cjs", "esm"],
"assets": [
{
"glob": "package.json",
Expand All @@ -77,9 +56,7 @@
"input": "./libs/providers/config-cat-web",
"output": "./"
}
],
"buildableProjectDepsInPackageJsonType": "dependencies",
"updateBuildableProjectDepsInPackageJson": true
]
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion libs/providers/config-cat-web/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"noImplicitOverride": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noFallthroughCasesInSwitch": true
},
"files": [],
"include": [],
Expand Down
5 changes: 4 additions & 1 deletion libs/providers/config-cat/package.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
{
"name": "@openfeature/config-cat-provider",
"version": "0.7.2",
"license": "Apache-2.0",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.13.5",
"configcat-node": "^11.3.1"
"configcat-node": "^11.3.1",
"@openfeature/config-cat-core": "0.1.0",
"configcat-common": "9.3.1"
}
}
37 changes: 7 additions & 30 deletions libs/providers/config-cat/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,37 +17,19 @@
]
},
"lint": {
"executor": "@nx/linter:eslint",
"outputs": [
"{options.outputFile}"
],
"options": {
"lintFilePatterns": [
"libs/providers/config-cat/**/*.ts"
]
}
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
},
"test": {
"executor": "@nx/jest:jest",
"outputs": [
"{workspaceRoot}/coverage/{projectRoot}"
],
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "libs/providers/config-cat/jest.config.ts",
"passWithNoTests": true
},
"configurations": {
"ci": {
"ci": true,
"codeCoverage": true
}
"jestConfig": "libs/providers/config-cat/jest.config.ts"
}
},
"package": {
"executor": "@nx/rollup:rollup",
"outputs": [
"{options.outputPath}"
],
"outputs": ["{options.outputPath}"],
"options": {
"project": "libs/providers/config-cat/package.json",
"outputPath": "dist/libs/providers/config-cat",
Expand All @@ -57,10 +39,7 @@
"generateExportsField": true,
"umdName": "config-cat",
"external": "all",
"format": [
"cjs",
"esm"
],
"format": ["cjs", "esm"],
"assets": [
{
"glob": "package.json",
Expand All @@ -77,9 +56,7 @@
"input": "./libs/providers/config-cat",
"output": "./"
}
],
"buildableProjectDepsInPackageJsonType": "dependencies",
"updateBuildableProjectDepsInPackageJson": true
]
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion libs/providers/config-cat/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"noImplicitOverride": true,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noFallthroughCasesInSwitch": true
},
"files": [],
"include": [],
Expand Down
3 changes: 2 additions & 1 deletion libs/providers/env-var/package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{
"name": "@openfeature/env-var-provider",
"version": "0.3.1",
"license": "Apache-2.0",
"scripts": {
"publish-if-not-exists": "cp $NPM_CONFIG_USERCONFIG .npmrc && if [ \"$(npm show $npm_package_name@$npm_package_version version)\" = \"$(npm run current-version -s)\" ]; then echo 'already published, skipping'; else npm publish --access public; fi",
"current-version": "echo $npm_package_version"
},
"peerDependencies": {
"@openfeature/server-sdk": "^1.13.0"
}
}
}
Loading
Loading