fix tests

Signed-off-by: Kavindu Dodanduwa <[email protected]>
open-feature · Dec 11, 2023 · f03e980 · f03e980
1 parent 22b8db8
commit f03e980
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 16 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/ProviderRepository.java b/src/main/java/dev/openfeature/sdk/ProviderRepository.java
@@ -106,16 +106,16 @@ private void prepareAndInitializeProvider(@Nullable String clientName,
               BiConsumer<FeatureProvider, String> afterError,
               boolean waitForInit) {
 
-        // provider is set immediately, on this thread
-        FeatureProvider oldProvider = clientName != null
-                ? this.providers.put(clientName, newProvider)
-                : this.defaultProvider.getAndSet(newProvider);
-
         if (!isProviderRegistered(newProvider)) {
             // only run afterSet if new provider is not already attached
             afterSet.accept(newProvider);
         }
 
+        // provider is set immediately, on this thread
+        FeatureProvider oldProvider = clientName != null
+                ? this.providers.put(clientName, newProvider)
+                : this.defaultProvider.getAndSet(newProvider);
+
         if (waitForInit) {
             initializeProvider(newProvider, afterInit, afterShutdown, afterError, oldProvider);
         } else {

diff --git a/src/test/java/dev/openfeature/sdk/ProviderRepositoryTest.java b/src/test/java/dev/openfeature/sdk/ProviderRepositoryTest.java
@@ -141,17 +141,6 @@ void shouldAvoidAdditionalInitializationCallIfProviderHasBeenInitializedAlready(
 
                 verify(provider, never()).initialize(any());
             }
-
-            @Test
-            @DisplayName("Should allow same provider to be registered with multiple names")
-            void allowSameProviderOnMultipleNames() throws Exception {
-                FeatureProvider provider = createMockedProvider();
-
-                setFeatureProvider(CLIENT_NAME, provider);
-                setFeatureProvider(ANOTHER_CLIENT_NAME, provider);
-
-                verify(provider, atMostOnce()).initialize(any());
-            }
         }
     }