Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Environment Variable Provider #312

Merged
merged 15 commits into from
Mar 12, 2025
Merged

feat: Environment Variable Provider #312

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9351e0e
First draft of environment variable provider
MJRichardson Feb 3, 2025
f6d9f2e
Added tests
MJRichardson Feb 4, 2025
3e9ecce
added README.md
MJRichardson Feb 4, 2025
b31a35f
added test resolving via client
MJRichardson Feb 4, 2025
cf72217
Added project metadata
MJRichardson Feb 5, 2025
5128e3b
moved project folders to correct location
MJRichardson Feb 5, 2025
5ec26ca
comments and tidying
MJRichardson Feb 5, 2025
f35f6a8
cleanup test proj file
MJRichardson Feb 6, 2025
43e1901
Apply suggestions from code review
MJRichardson Mar 10, 2025
5f463ce
minor formatting
MJRichardson Mar 10, 2025
b50eade
When env var not found, returns flag not found error. From code review.
MJRichardson Mar 10, 2025
2bec41e
added version.txt and updated release-please-config.json
MJRichardson Mar 10, 2025
6a0125e
formatting
MJRichardson Mar 10, 2025
844634a
Merge branch 'main' into michrich/env-var-provider
MJRichardson Mar 10, 2025
21dbdbb
corrected using statements in README
MJRichardson Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup test proj file 
Signed-off-by: Michael Richardson <[email protected]>
  • Loading branch information
@MJRichardson
MJRichardson committed Mar 10, 2025
commit f35f6a8c6433c53f54298cf4417bb7facd448b96
4 changes: 1 addition & 3 deletions src/OpenFeature.Contrib.Providers.EnvVar/OpenFeature.Contrib.Providers.EnvVar.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>disable</ImplicitUsings>
<PackageId>OpenFeature.Contrib.Providers.EnvVar</PackageId>
<VersionNumber>0.0.1</VersionNumber> <!--x-release-please-version -->
<VersionPrefix>$(VersionNumber)</VersionPrefix>
<AssemblyVersion>$(VersionNumber)</AssemblyVersion>
Expand All @@ -11,5 +10,4 @@
<Authors>Octopus Deploy</Authors>
</PropertyGroup>


</Project>
4 changes: 1 addition & 3 deletions test/OpenFeature.Contrib.Providers.EnvVar.Test/EnvVarProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace OpenFeature.Contrib.Providers.EnvVar.Test
{

public class EnvVarProviderTests
{
[Theory]
Expand Down Expand Up @@ -140,7 +139,7 @@ await ExecuteResolveErrorTest(prefix, flagKey, defaultValue, ErrorType.TypeMisma
public async Task ResolveStructureValueAsync_WhenEnvironmentVariablePresent_ShouldReturnValue(string prefix,
string flagKey, string value, string defaultValue)
{
Environment.SetEnvironmentVariable(prefix + flagKey, value.ToString());
Environment.SetEnvironmentVariable(prefix + flagKey, value);

var provider = new EnvVarProvider(prefix);
var resolutionDetails = await provider.ResolveStructureValueAsync(flagKey, new Value(defaultValue));
Expand Down Expand Up @@ -185,6 +184,5 @@ private async Task ExecuteResolveErrorTest<T>(string prefix, string flagKey, T d

Assert.Equal(expectedErrorType, exception.ErrorType);
}

}
}
10 changes: 1 addition & 9 deletions ...penFeature.Contrib.Providers.EnvVar.Test/OpenFeature.Contrib.Providers.EnvVar.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<ImplicitUsings>disable</ImplicitUsings>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="AutoFixture.Xunit2" Version="4.17.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\OpenFeature.Contrib.Providers.EnvVar\OpenFeature.Contrib.Providers.EnvVar.csproj" />
</ItemGroup>

</Project>