Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bandwidth information requirement to devices datasheet #89

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add bandwidth information requirement to devices datasheet #89

wants to merge 2 commits into from

Conversation

aacuevas
Copy link
Contributor

@aacuevas aacuevas commented Mar 4, 2025

@aacuevas aacuevas requested a review from jonnew March 4, 2025 00:50
jonnew
jonnew approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@jonnew jonnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor edits. Please proofread before merge.

aacuevas
aacuevas commented Mar 4, 2025
View reviewed changes
source/hw-spec/devices/datasheet.rst
minimum and maximum rates at which data might be produced.
- For streams with periodic data production or consumption, the datasheet must
specify the frequency or possible configurable frequencies at which frames are
being transmitted or consumed.
Copy link
Contributor Author

@aacuevas aacuevas Mar 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no sure about the "consume" here. Before, it made sense as the text talks about producing and thus consuming data as well, since it implies a directionality. However, since in this line "transmitted" is being used, I feel data is "transmitted through a channel" with independence of their directionality. Adding consumption or production here again feels too redundant and cluttery to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonnew jonnew jonnew approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bandwidth information to device datasheets
2 participants
@aacuevas @jonnew