-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TES import #1
TES import #1
Conversation
Looks good! 👍 Generally, my concern is the proliferation of duplication of code that is starting to occur in these repos:
I think we need to start thinking carefully how to split up things conceptually and make sure import things whenever possible. |
I removed the As soon as we resolve ohsu-comp-bio/funnel#481 I'll remove some of the events package too. |
Makefile
Outdated
-I ./ \ | ||
-I $$GOPATH/src/github.com/golang/protobuf/ptypes/struct/ \ | ||
-I $$GOPATH/src/github.com/golang/protobuf/ptypes/timestamp/ \ | ||
--go_out=Mtes/tes.proto=github.com/ohsu-comp-bio/tes:. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command should be updated now that you removed the tes.proto file
I've added new functionality to this PR, so please review again. This creates additional vertex types for each task. Still need edges. |
Ok, the latest commit is in decent shape:
I didn't put a ton of thought into vertex/edge label names, GID formats, etc. I'm pretty sure I'm diverging from BMEG on that so far. Probably cleanup to be done there. Also, we should have a style guide for those things. |
Added a cobra CLI. I'm done adding to this branch now. |
@adamstruck requested tests and the basics of a Go project, so I guess I'm not done yet. Added tidy/lint in the last commit. |
Rough draft of pulling Funnel events from Kafka and writing them into Arachne.