Add mnemonics to reviews #84
Conversation
This commit adds a "3rd face" to the review cards, that can be toggled on/off via a tap after the answer has been revealed.
There was a problem hiding this comment.
@xiprox This is awesome! tested it, works really well. I also love how you handled it, toggling mnemonics on the same card. Super simple and minimalistic, love it! Thank you so much for your contribution.
This feature isn't exactly obvious to the user. Might want to add a hint.
Agreed! Maybe you can add a small text below the meaning (with a muted colour) that writes something like "Tap (click/space on web) to see the mnemonics".
Also one small request, could you swap the text colour on dark mode? (Maybe you can use the same colour with the meaning text)
(also noticing options menu needs some dark mode fixes as well 😅)
|
Glad you liked it! I've updated the PR with the changes you mentioned. One idea I had was to stop showing the hint after the user has learned the mnemonic toggle (i.e. toggled 10 times or something). Couldn't quite figure our how your state management / persistence works so I'll leave that to you if you want to implement it. |
This PR adds a "3rd face" to the review cards, that can be toggled on/off via a tap after the answer has been revealed, as mentioned in #68. Also makes some visual improvements to the
TextWithMarkupscomponent (as can be seen in the screenshot below).I believe showing mnemonics only is enough for this app — keeps it simple. They cover the scenario where you fail to recall a review item and the answer alone isn't enough to jog your memory. Most users likely use Juken supplementary to another app and so they can look up extra information such as sample sentences there.
Considerations:
Releasing a card before activation threshold in either direction causes a tap event to be handled and thus toggles the mnemonic.This seems to be a problem only on the web if you are dragging with a mouse. Probably not a big deal.The experience on the web (with a keyboard) hasn't been considered thoroughly. Maybe it can work similarly to mobile and toggle on spacebar press.Done.These are things I'd like to iron out before I call this feature complete but wanted to hear your thoughts first.