Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back-to-back feature (#56) #60

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Add back-to-back feature (#56) #60

merged 5 commits into from
Aug 13, 2020

Conversation

joyalicegu
Copy link
Contributor

#56

  • Add toggles for back-to-back mode and meaning-reading order
  • Modify adjustQueue to sort back-to-back
  • Call adjustQueue on queue creation and when settings change
  • Change requeueing logic in back-to-back mode:
    • In back-to-back mode, a card is requeued with its corresponding card to form a consecutive pair if the corresponding card is in the deck and not at the top.
    • Otherwise, it is queued so that it doesn't interrupt an existing reading-meaning pair.

Please let me know if you have any suggestions for improvement!

In back-to-back mode, a card is requeued with its corresponding card
to form a consecutive pair if the corresponding card is in the deck and
not at the top. Otherwise, it is queued so that it doesn't interrupt an
existing reading-meaning pair.
@oguzgelal
Copy link
Owner

Thanks @joyalicegu this looks great! :) Today I'll give this a little test, then approve and create a new version.

Copy link
Owner

@oguzgelal oguzgelal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@oguzgelal oguzgelal merged commit 0f3e9a6 into oguzgelal:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants