fix: Fix Polygon Repair and Empty Polygon Issues, see #1118 #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues with invalid polygons, including empty polygon handling, by adding utility functions to repair polygons and multipolygons as well as converting COCO segmentation data to shapely geometries.
- Introduces repair_polygon and repair_multipolygon functions that fix invalid geometries using buffer(0).
- Adds coco_segmentation_to_shapely to correctly process segmentation data and integrates it into get_merged_mask.
Comments suppressed due to low confidence (1)
sahi/postprocess/utils.py:121
- [nitpick] Consider updating the error message to include examples of valid segmentation formats for improved clarity.
raise ValueError("segmentation must be List or List[List]")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1118, here is the, hopefully, fixed version of the bug fix.