Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend event logs #4200

Merged
merged 4 commits into from
Feb 7, 2025
Merged

feat: extend event logs #4200

merged 4 commits into from
Feb 7, 2025

Conversation

shpran
Copy link
Contributor

@shpran shpran commented Feb 4, 2025 •
edited by jira bot
Loading

ADF-1851

Changes

  • Added new event to cover translation actions:
    • Create
    • Update
    • Delete
  • New event is triggered in related services to create/update/delete a translation
  • New event will share the following information:
    • Action (create/update/delete)
    • Original resource URI
    • Translation resource URI
    • Locale code
    • Additional data, e.g. changed properties (old -> new)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Front-end summary Node 18

💯 Total ✅ Passed ⏭️ Skipped ❌ Failed
241 241 0 0

@shpran shpran mentioned this pull request Feb 4, 2025
Merged
1 task
@shpran shpran force-pushed the feat/adf-1851/extend-event-logs branch from e1cce2a to 22e059b Compare February 4, 2025 01:40
@shpran shpran force-pushed the feat/adf-1851/extend-event-logs branch from 22e059b to 89300aa Compare February 4, 2025 01:48
@shpran shpran requested a review from gabrielfs7 February 4, 2025 16:26
gabrielfs7
gabrielfs7 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shpran !

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2025

Version

Target Version 54.31.0
Last version 54.30.1

There are 0 BREAKING CHANGE, 1 feature, 0 fix

@shpran shpran merged commit fc299a3 into develop Feb 7, 2025
5 checks passed
@shpran shpran deleted the feat/adf-1851/extend-event-logs branch February 7, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielfs7 gabrielfs7 gabrielfs7 approved these changes

@Nevermind23 Nevermind23 Nevermind23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shpran @gabrielfs7 @Nevermind23