go/runtime/registry/host: Ignore key manager quote policy update feature #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/bugfix/no-km-policy-updates
branch
2 times, most recently
from
3a14434 to
7566543
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
If the key manager policy and status update watcher started before the runtime active version was ready, it failed to fetch the runtime info and stopped. Therefore, the key manager status and quote policy were never updated, causing the key manager runtime client to reject incoming Noise session requests since the policy was not set.
peternose
force-pushed
the
peternose/bugfix/no-km-policy-updates
branch
from
7566543 to
f993133
Compare
kostko
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why this bug appeared now and not sooner 🤔