go/common/sync: Add IsRunning function to sync.One

.changelog/5536.feature.md

@@ -0,0 +1 @@
+go/common/sync: Add IsRunning function to sync.One

go/common/sync/sync.go

@@ -13,6 +13,9 @@ type One interface {
 	// TryStop stops the running function, if any. This method blocks until
 	// the function finishes its work.
 	TryStop() bool
+
+	// IsRunning returns true iff the function is running.
+	IsRunning() bool
 }
 
 type one struct {
@@ -39,6 +42,7 @@ func NewOne() One {
 	}
 }
 
+// TryStart implements One.
 func (s *one) TryStart(fn func(ctx context.Context)) bool {
 	// Allow running only one function at a time.
 	select {
@@ -75,6 +79,7 @@ func (s *one) TryStart(fn func(ctx context.Context)) bool {
 	return true
 }
 
+// TryStop implements One.
 func (s *one) TryStop() bool {
 	select {
 	case ctrl := <-s.ctrlCh:
@@ -86,3 +91,8 @@ func (s *one) TryStop() bool {
 		return false
 	}
 }
+
+// IsRunning implements One.
+func (s *one) IsRunning() bool {
+	return len(s.startCh) > 0
+}

go/p2p/peermgmt/peermgr.go

@@ -123,9 +123,7 @@ func (m *PeerManager) PeerTagger() api.PeerTagger {
 
 // Start starts the background services required for the peer manager to work.
 func (m *PeerManager) Start() {
-	m.startOne.TryStart(func(ctx context.Context) {
-		go m.run(ctx)
-	})
+	m.startOne.TryStart(m.run)
 }
 
 // Stop stops all background services. The method blocks until all services finish their work.