Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT/22.1.x] Multiple backports #4688

Merged
merged 3 commits into from
Apr 23, 2022
Merged

[BACKPORT/22.1.x] Multiple backports #4688

merged 3 commits into from
Apr 23, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 23, 2022

@kostko kostko added the c:backport Category: backport to stable branch label Apr 23, 2022
kostko added 3 commits April 23, 2022 20:46
@kostko
go/worker/compute: Only advertise active version for TEE runtimes
0e8ada1 
Previously this caused additional downtime on upgrades due to capability
updates not being allowed.
@kostko
go/worker/compute: Do not advertise old versions
654d5d9
@kostko
go/runtime/host/sandbox: Properly handle clone3 in seccomp policy
0131668 
We need to handle the clone3 syscall in a special manner as there are
several complications to its handling:

- Newer glibc versions will try clone3 first and if they see EPERM they
  will instantly fail making the program unable to spawn threads.

- The clone3 syscall is much more complex than clone and so we can't
  simply inspect its flags as we do for clone.

Therefore we need to reject the syscall with ENOSYS, causing fallback to
clone.
@kostko kostko force-pushed the kostko/stable/22.1.x/backport-multi-1 branch from 9ed96d2 to 0131668 Compare April 23, 2022 18:46
@kostko kostko enabled auto-merge April 23, 2022 18:59
@codecov
Copy link

codecov bot commented Apr 23, 2022

Codecov Report

Merging #4688 (0131668) into stable/22.1.x (a361970) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@                Coverage Diff                @@
##           stable/22.1.x    #4688      +/-   ##
=================================================
- Coverage          66.88%   66.86%   -0.02%     
=================================================
  Files                431      431              
  Lines              48890    48899       +9     
=================================================
- Hits               32698    32695       -3     
- Misses             12147    12154       +7     
- Partials            4045     4050       +5
Impacted Files Coverage Δ
go/runtime/host/sandbox/process/seccomp_linux.go 46.15% <33.33%> (-3.85%) ⬇️
go/worker/compute/executor/committee/node.go 71.08% <66.66%> (-0.02%) ⬇️
go/worker/common/p2p/txsync/client.go 46.87% <0.00%> (-21.88%) ⬇️
.../worker/compute/executor/committee/transactions.go 64.51% <0.00%> (-9.68%) ⬇️
go/worker/common/p2p/rpc/server.go 80.76% <0.00%> (-9.62%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/worker/common/p2p/rpc/client.go 77.15% <0.00%> (-4.07%) ⬇️
go/worker/common/p2p/txsync/server.go 65.38% <0.00%> (-3.85%) ⬇️
go/consensus/tendermint/full/services.go 77.69% <0.00%> (-3.85%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f6ce6...0131668. Read the comment docs.

@kostko kostko merged commit 65ec893 into stable/22.1.x Apr 23, 2022
@kostko kostko deleted the kostko/stable/22.1.x/backport-multi-1 branch April 23, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yawning Yawning Yawning approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
c:backport Category: backport to stable branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostko @Yawning